Apply latest token ds-auro-icon-size and adjust styles applied to icon #55

[rmenner]

Alaska Airlines Pull Request

Type of change:

Please delete options that are not relevant.

• New capability
• Revision of an existing capability
• Infrastructure change (automation, etc.)
• Other (please elaborate)

Checklist:

• My update follows the CONTRIBUTING guidelines of this project
• I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

Summary by Sourcery

Apply the latest 'ds-auro-icon-size' token to icon styles and adjust the styling logic for icons in the AuroNav component to enhance consistency and maintainability.

New Features:

• Apply the latest token 'ds-auro-icon-size' to icon styles.

Enhancements:

• Adjust icon styles to use the 'ds-auro-icon-size' token for consistency.

[sourcery-ai]

Reviewer's Guide by Sourcery

This PR updates the icon styling implementation in the navigation component to use the latest design system token ds-auro-icon-size. The changes simplify the icon styling by replacing individual style properties with a single CSS custom property.

Updated class diagram for AuroNav component

classDiagram
    class AuroNav {
        +insertIcon(breadcrumb, category, name, size)
    }
    note for AuroNav "Updated icon styling to use --ds-auro-icon-size token"

Loading

File-Level Changes

Change	Details	Files
Updated icon styling to use the new design system token	Replaced individual width and height styles with the ds-auro-icon-size token Removed explicit line-height and top position styles Updated icon size parameter format to use CSS custom property syntax	src/auro-nav.js

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @rmenner - I've reviewed your changes - here's some feedback:

Overall Comments:

• The removal of line-height and top positioning properties might affect icon-text alignment. Was this intentional, or should these be preserved/replaced with equivalent custom properties?

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[jordanjones243]

Need to rebase this repo off of main

[blackfalcon]

🎉 This PR is included in version 2.2.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀