Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safari UI fix #264

Merged
merged 4 commits into from
Oct 10, 2024
Merged

Safari UI fix #264

merged 4 commits into from
Oct 10, 2024

Conversation

rmenner
Copy link
Contributor

@rmenner rmenner commented Oct 9, 2024

Alaska Airlines Pull Request

Type of change:

Please delete options that are not relevant.

  • New capability
  • Revision of an existing capability
  • Infrastructure change (automation, etc.)
  • Other (please elaborate)

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

Summary by Sourcery

Fix a UI issue in Safari by updating the input container color to transparent in the color.scss file.

Bug Fixes:

  • Fix the UI issue in Safari by changing the input container color to transparent.

@rmenner rmenner self-assigned this Oct 9, 2024
@rmenner rmenner requested a review from a team as a code owner October 9, 2024 23:15
Copy link

sourcery-ai bot commented Oct 9, 2024

Reviewer's Guide by Sourcery

This pull request addresses a UI fix for Safari by modifying a CSS variable in the color.scss file. The change replaces the background-color property with a container-color property, both set to transparent, to ensure consistent styling across browsers.

User journey diagram for Safari UI fix

journey
  title Safari UI Fix
  section Before Fix
    User: Safari displays incorrect background color
  section After Fix
    User: Safari displays correct container color
Loading

File-Level Changes

Change Details Files
Replaced CSS variable for input background color with container color
  • Removed --ds-auro-input-background-color: unset !important;
  • Added --ds-auro-input-container-color: transparent !important;
src/color.scss

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @rmenner - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Could you explain the reasoning behind changing the variable name from 'background-color' to 'container-color'? Is this part of a larger standardization effort?
  • The use of '!important' in CSS can lead to maintenance issues. Have you considered alternative ways to achieve the desired styling without relying on '!important'?
  • As this is labeled a 'Safari UI fix', has this change been tested across different browsers to ensure cross-browser compatibility?
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

github-actions bot commented Oct 9, 2024

Surge demo deployment failed! 😭

@rmenner
Copy link
Contributor Author

rmenner commented Oct 9, 2024

Hey @rmenner - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Could you explain the reasoning behind changing the variable name from 'background-color' to 'container-color'? Is this part of a larger standardization effort?
  • The use of '!important' in CSS can lead to maintenance issues. Have you considered alternative ways to achieve the desired styling without relying on '!important'?
  • As this is labeled a 'Safari UI fix', has this change been tested across different browsers to ensure cross-browser compatibility?

Here's what I looked at during the review
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

I have confirmed the use of !important was unnecessary and removed them. As far as background-color vs container-color the previous css prop was not the correct one. Lastly this has been tested in Safari, FF, Edge, and Chrome.

@rmenner rmenner linked an issue Oct 10, 2024 that may be closed by this pull request
@rmenner rmenner merged commit ef66bbb into main Oct 10, 2024
6 of 7 checks passed
@rmenner rmenner deleted the rmenner/263/safari-ui-fix branch October 10, 2024 19:41
@blackfalcon
Copy link
Member

🎉 This PR is included in version 3.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blackfalcon blackfalcon added the released Completed work has been released label Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Completed work has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extra outline when tab focus is used in Safari
3 participants