-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Safari UI fix #264
Safari UI fix #264
Conversation
Reviewer's Guide by SourceryThis pull request addresses a UI fix for Safari by modifying a CSS variable in the color.scss file. The change replaces the background-color property with a container-color property, both set to transparent, to ensure consistent styling across browsers. User journey diagram for Safari UI fixjourney
title Safari UI Fix
section Before Fix
User: Safari displays incorrect background color
section After Fix
User: Safari displays correct container color
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @rmenner - I've reviewed your changes - here's some feedback:
Overall Comments:
- Could you explain the reasoning behind changing the variable name from 'background-color' to 'container-color'? Is this part of a larger standardization effort?
- The use of '!important' in CSS can lead to maintenance issues. Have you considered alternative ways to achieve the desired styling without relying on '!important'?
- As this is labeled a 'Safari UI fix', has this change been tested across different browsers to ensure cross-browser compatibility?
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Surge demo deployment failed! 😭 |
I have confirmed the use of |
🎉 This PR is included in version 3.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Alaska Airlines Pull Request
Type of change:
Please delete options that are not relevant.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team
Summary by Sourcery
Fix a UI issue in Safari by updating the input container color to transparent in the color.scss file.
Bug Fixes: