Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New 1 column page layout. #129

Closed
6 tasks
braven112 opened this issue Nov 17, 2022 · 2 comments · Fixed by #154
Closed
6 tasks

New 1 column page layout. #129

braven112 opened this issue Nov 17, 2022 · 2 comments · Fixed by #154
Assignees
@marnel-mangrubang
Labels
auro-wcss Type: Feature New Feature Type: Question Further information is requested
Milestone
Grid System

Comments

@braven112
Copy link
Member

braven112 commented Nov 17, 2022 •
edited by marnel-mangrubang
Loading

User story

As a designer or engineer I want to have a one column standard page layout available to use so that I can use the new auro breakpoints and have consistent page sizes across products.

Here is the user story the content team is working on:
https://dev.azure.com/itsals/E_Retain_Content/_boards/board/t/E_Retain_Content%20Team/Stories/?workitem=853679

Definition of “Done” (exit criteria)

  • The new layout uses the dynamic spacing tokens
  • Setup a quick call with Jason, Dale or Jordan on how to use the doc site.
  • Make a class in WCSS that handles the max-width and padding for a 1 column layout.
  • New layout class has been added to WCSS
  • An example on the Auro doc site of a 1 column page layout using our new grid tokens (sync with June on how/where to display this)
  • Integrate common components that would be often used 1 page layouts like auro-nav - breadcrumbs, auro-header along with lorem ipsum text.
@braven112 braven112 added this to the Grid System milestone Nov 17, 2022
@blackfalcon blackfalcon self-assigned this Jan 4, 2023
@blackfalcon
Copy link
Member

@braven112 The team needs to have more discussion on what the work for this actually is.

  • Is there a design spec? What is the new layout?
  • What is the assumption of selectors to be added to WCSS?
  • What are 'the dynamic spacing tokens'?

@blackfalcon blackfalcon added the Type: Question Further information is requested label Jan 20, 2023
@blackfalcon
Copy link
Member

@leeejune will schedule meeting with @blackfalcon to understand how to move forward with this request.

@blackfalcon blackfalcon mentioned this issue Feb 8, 2023
Closed
@marnel-mangrubang marnel-mangrubang linked a pull request May 12, 2023 that will close this issue
feat(gridstyle): add a new class for one column grid layout #154
Merged
3 tasks
marnel-mangrubang pushed a commit that referenced this issue May 15, 2023
@chethanayasa @marnel-mangrubang
feat: create a new class for grid styling #129
49a2f13
marnel-mangrubang added a commit that referenced this issue May 15, 2023
@marnel-mangrubang
feat: update the sass variables used in new grid class #129
d0f6cd3
blackfalcon pushed a commit that referenced this issue May 18, 2023
@marnel-mangrubang @blackfalcon
feat(grid mixin): add support for new grid mixin #129
eb156ca 
This commit will add support for the grid concepts,
starting with a one col layout.

Changes to be committed:
modified:   docs/index.html
new file:   src/_grids.scss
modified:   src/elementDemoStyles/elementDemoStyles.scss
modified:   tests/styleTest.scss
blackfalcon pushed a commit that referenced this issue May 18, 2023
@marnel-mangrubang @blackfalcon
feat(grid mixin): add support for new grid mixin #129
01a615d 
This commit will add support for the grid concepts,
starting with a one col layout.

Changes to be committed:
modified:   docs/index.html
new file:   src/_grids.scss
modified:   src/elementDemoStyles/elementDemoStyles.scss
modified:   tests/styleTest.scss
new file:   tests/grids.spec.scss
blackfalcon pushed a commit that referenced this issue May 18, 2023
@marnel-mangrubang @blackfalcon
feat(grid mixin): add support for new grid mixin #129
00ecfd2 
This commit will add support for the grid concepts,
starting with a one col layout.

Changes to be committed:
modified:   docs/index.html
new file:   src/_grids.scss
modified:   src/elementDemoStyles/elementDemoStyles.scss
modified:   tests/styleTest.scss
new file:   tests/grids.spec.scss
blackfalcon pushed a commit that referenced this issue May 18, 2023
@semantic-release-bot
chore(release): 4.4.0 [skip ci]
c577a5e 
# [4.4.0](v4.3.1...v4.4.0) (2023-05-18)

### Features

* **grid mixin:** add support for new grid mixin [#129](#129) ([00ecfd2](00ecfd2))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marnel-mangrubang marnel-mangrubang

Labels
auro-wcss Type: Feature New Feature Type: Question Further information is requested
Projects
None yet
Milestone
Grid System
Development

Successfully merging a pull request may close this issue.

feat(gridstyle): add a new class for one column grid layout AlaskaAirlines/WebCoreStyleSheets
3 participants
@blackfalcon @braven112 @marnel-mangrubang