Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update per new size tokens #128

Closed
blackfalcon opened this issue Nov 3, 2022 · 0 comments · Fixed by #145
Closed

Update per new size tokens #128

blackfalcon opened this issue Nov 3, 2022 · 0 comments · Fixed by #145
Assignees
Labels
Milestone

Comments

@blackfalcon
Copy link
Member

The following code from WCSS is no longer compatible with updated design tokens do to the deprecation of sizes like xxl, etc...

/// **Dependency:** `$npm i alaskaairux/design-tokens`
/// @group utility-layout
/// @param {string} $auro-spacing-types [inline, stack] inline - L/R, stack - top/bottom
/// @param {string} $auro-spacing-options [none, xxxs, xxs, xs, sm, md, lg, xl, xxl, xxxl] defines value applied
/// @example css - Example output css
/// .util_stackPaddingXxxs--top {
/// padding-top: 0.125rem;
/// }
/// .util_stackPaddingXxxs--bottom {
/// padding-bottom: 0.125rem;
/// }
/// .util_stackMarginXxxs--top {
/// margin-top: 0.125rem;
/// }
/// .util_stackMarginXxxs--bottom {
/// margin-bottom: 0.125rem;
/// }
/// @example scss - import dependencies
/// @import "./node_modules/@alaskaairux/design-tokens/dist/tokens/SCSSVariableMap";
/// @import "./node_modules/@aurodesignsystem/webcorestylesheets/dist/utilityMixins/spacingUtility";
/// @example scss - import with custom over-rides
/// $auro-spacing-types: inline;
/// $auro-spacing-options: xxxs;
/// @import "./node_modules/@alaskaairux/design-tokens/dist/tokens/SCSSVariableMap";
/// @import "./node_modules/@aurodesignsystem/webcorestylesheets/dist/utilityMixins/spacingUtility";

The scope of this request is to update the mixin to support and document the new size tokens.

Exit criteria

This is done when the new mixin has deprecated the legacy tokens in place for the new 100, 200, etc.. size tokens.

@braven112 braven112 added this to the Grid System milestone Dec 12, 2022
@blackfalcon blackfalcon self-assigned this Jan 4, 2023
@blackfalcon blackfalcon removed their assignment Jan 20, 2023
@jordanjones243 jordanjones243 linked a pull request Feb 6, 2023 that will close this issue
6 tasks
@jordanjones243 jordanjones243 self-assigned this Feb 6, 2023
blackfalcon pushed a commit that referenced this issue Feb 7, 2023
# [4.3.0](v4.2.0...v4.3.0) (2023-02-07)

### Features

* **size:** use new and deprecate legacy size tokens [#128](#128) ([1eaede6](1eaede6))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants