-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Sparks of the Future blocks to the grid analyzer. #37
Conversation
Oh wait, I edited the generated file in lib for the version, not the source. ;) |
e50f8a2
to
b85614e
Compare
Looks good, I will give it a test-run on the server and then merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried it out and run into problems. First need to bump steam version to trigger re-crawl, which works fine. Second need to add Symbols too, but it even after doing so it somehow didn't take it into account in praising.
Please update the PR and I will test again
7648212
to
6f1a3d3
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs |
Ok, Cubeblocks_Symbols.sbc is in now. |
Thanks, I will give it another test tonight Note to myself - few testcases: |
Thumps up! Did you figure out what the problem was when you first ran the test? Was that just stale cached data? |
Nope, I guess just a random human error. Also, for next days we will have this problem #7 |
Adds Sparks of the Future blocks to the grid analyzer.
That one line with the removes trailing space was my editor doing it's thing.