Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use powershell for clipboard #123

Merged
merged 1 commit into from
Apr 28, 2024

Conversation

seth-js
Copy link
Contributor

@seth-js seth-js commented Apr 27, 2024

Switched to powershell to avoid text escape issues, and to remove the automatic newline.

I've tested it with German, Italian, Russian, and Japanese.

Switched to `powershell` to avoid text escape issues, and to remove the automatic newline.
@tatsumoto-ren
Copy link
Member

Hello👋. I wish you'd reached out prior to working on this. We discuss new features in our community before they're introduced. There's one small thing that needs to be addressed, being the performance hit. #20 (comment)
If it's negligible then it's fine to replace cmd with powershell.

@tatsumoto-ren tatsumoto-ren merged commit aeb451f into Ajatt-Tools:master Apr 28, 2024
@seth-js seth-js deleted the powershell-clipboard branch April 28, 2024 22:36
@Toastbroti
Copy link

This commit breaks copying text that includes “” quotes

@seth-js
Copy link
Contributor Author

seth-js commented May 20, 2024

@Toastbroti

Thanks for letting me know. PR #125 should fix this issue.

@tatsumoto-ren
Copy link
Member

@seth-js I couldn't see you being active in the chat so I'll repost this here.

Hello, I was trying to install the latest version of mpvacious 0.35 on windows but the autocopy function was not working, 0.31 version works perfectly

I'm using windows 11, it always failed to work
I was using it with Chinese subtitles

@seth-js
Copy link
Contributor Author

seth-js commented Jun 20, 2024

@tatsumoto-ren

I can test it on a Windows 11 machine tomorrow and see what's going on.

@seth-js
Copy link
Contributor Author

seth-js commented Jun 20, 2024

@tatsumoto-ren

I just tested v0.35 on Windows 11, and everything was working as expected, including with Chinese subs. I'd have to see the user's mpv command output when subtitles appear to further look into the problem.

It's up to you if you want to revert back to cmd to maximize compatibility, or continue trying to troubleshoot their issue.

@tatsumoto-ren
Copy link
Member

@seth-js I already merged #128
In the future I probably will try to come up with a more universal solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants