Code refactoring #19
Merged
Code refactoring #19
+219
−224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HelenMel
reviewed
Mar 25, 2021
HelenMel
reviewed
Mar 25, 2021
src/main/java/io/aiven/kafka/connect/http/sender/HttpSender.java
Outdated
Show resolved
Hide resolved
|
Looks good! 2 small comments |
willyborankin
force-pushed
the
before-ouath2-refactoring
branch
from
4f0a2a2 to
f6daba3
Compare
HelenMel
reviewed
Mar 25, 2021
src/main/java/io/aiven/kafka/connect/http/sender/HttpSender.java
Outdated
Show resolved
Hide resolved
1. Moved RecordSender class into package io.aiven.kafka.connect.http.recordsender package 2. Moved HttpSender into io.aiven.kafka.connect.http.sender package and split up HttpSender behave for 2 diff auth type with auth and without auth 3. Moved backoff policy into HtpSender
willyborankin
force-pushed
the
before-ouath2-refactoring
branch
from
f6daba3 to
366ba0d
Compare
HelenMel
approved these changes
Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and split up HttpSender behave for 2 diff auth type with auth and without auth