Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linter warning for example #3

Merged
merged 3 commits into from
May 10, 2024
Merged

Conversation

LaStrada
Copy link
Member

@LaStrada LaStrada commented May 6, 2024

What

Fix a linter warning in the example. Also adding this as part of the CI job.

Why

  • There is no reason for not checking all examples as well as the airthings_sdk.

References

How to fill this template?
  • What: what changed, what do these changes mean? (high level)
  • Why: why these changes were made? (business case, technical context, etc.)
  • References: Links to Jira tasks, GitHub issues (use Closes #123) and PRs, or related documentation for context.

Use bullet points to be concise and to the point.

Expand this for infrastructure updates via Atlantis
  • Only atlantis can merge PRs in this repo, and it does so after automatically updating the github configuration, teams
    and repos.
  • Make sure your branch is up-to-date with main before running atlantis plan -p "production" and atlantis apply

@LaStrada LaStrada requested a review from HormCodes as a code owner May 6, 2024 22:56
@LaStrada LaStrada changed the title Refactor/test linter warning Fix linter warning for example May 8, 2024
@LaStrada LaStrada merged commit 940f6de into main May 10, 2024
5 checks passed
@LaStrada LaStrada deleted the refactor/test-linter-warning branch May 10, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants