Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Medium Refactorings #2

Merged
merged 6 commits into from
Apr 2, 2024
Merged

Medium Refactorings #2

merged 6 commits into from
Apr 2, 2024

Conversation

HormCodes
Copy link
Member

@HormCodes HormCodes commented Mar 8, 2024 •
edited
Loading

What

  • Examples from @LaStrada
  • CI/CD and fix some lint errors
  • Improve logic and standardise error handling

@HormCodes HormCodes force-pushed the refactor/hormcodes branch from 92a1b45 to 5145759 Compare March 8, 2024 11:02
@HormCodes HormCodes force-pushed the refactor/hormcodes branch from 5145759 to ef3d7e4 Compare March 8, 2024 11:04
@HormCodes HormCodes force-pushed the refactor/hormcodes branch from 82e4c51 to 2cda6f7 Compare March 8, 2024 14:23
@HormCodes HormCodes marked this pull request as ready for review March 8, 2024 14:24
@airthings-atlantis
Copy link
Contributor 

Error: This repo is not allowlisted for Atlantis.

@HormCodes HormCodes changed the title Refactor/hormcodes (wip) Medium Refactorings Mar 8, 2024
@HormCodes HormCodes requested a review from LaStrada March 8, 2024 14:42
LaStrada
LaStrada reviewed Mar 10, 2024
View reviewed changes
api/python/airthings_sdk/parser.py Outdated Show resolved Hide resolved
api/python/airthings_sdk/parser.py Outdated Show resolved Hide resolved
api/python/airthings_sdk/parser.py Outdated Show resolved Hide resolved
@HormCodes HormCodes force-pushed the refactor/hormcodes branch 2 times, most recently from 56c6e62 to 422e96a Compare March 15, 2024 11:51
@HormCodes HormCodes requested a review from LaStrada March 15, 2024 11:53
@HormCodes HormCodes force-pushed the refactor/hormcodes branch from 422e96a to 4a586ff Compare March 20, 2024 14:12
LaStrada
LaStrada approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@LaStrada LaStrada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@HormCodes HormCodes merged commit 2a40a56 into main Apr 2, 2024
5 checks passed
@HormCodes HormCodes deleted the refactor/hormcodes branch April 2, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaStrada LaStrada LaStrada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HormCodes @airthings-atlantis @LaStrada