Add missing types to FieldSet interface. #280
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
When you have lookup field in the table that refers to the column of type number or boolean, it's impossible to define its type as
number[]
norboolean[]
. In such situation the following compiler's error is reported.You can always defined such fields as
string[]
. However, this requires to cast types later in the code. For example, when field is numeric, the casting looks like the following:fields.price[0] as unknown as number
This works, but that's not be best practice using TypeScript.
What
This PR resolves above issue by extending
FieldSet
interface byReadonlyArray<number>
andReadonlyArray<boolean>
types.