Fixed an issue where a crash occurred when the policy value was empty…

… in SignedPolicy
AirenSoft · Oct 14, 2024 · 83cb9c8 · 83cb9c8
1 parent a65c593
commit 83cb9c8
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/src/projects/modules/access_control/signed_policy/signed_policy.cpp b/src/projects/modules/access_control/signed_policy/signed_policy.cpp
@@ -67,6 +67,12 @@ bool SignedPolicy::Process(const std::shared_ptr<const ac::RequestInfo> &request
 
 	// Extract policy
 	auto policy_base64 = url->GetQueryValue(policy_query_key);
+	if (policy_base64.IsEmpty())
+	{
+		SetError(ErrCode::NO_POLICY_VALUE_IN_URL, ov::String::FormatString("Policy value is empty in url(%s).", request_url_str.CStr()));
+		return false;
+	}
+
 	auto policy = ov::Base64::Decode(policy_base64, true);
 
 	if (ProcessPolicyJson(policy->ToString()) == false)

diff --git a/src/projects/modules/access_control/signed_policy/signed_policy.h b/src/projects/modules/access_control/signed_policy/signed_policy.h
@@ -13,6 +13,7 @@ class SignedPolicy
 		INIT = 0,
 		PASSED = 1,
 		NO_POLICY_KEY_IN_URL,
+		NO_POLICY_VALUE_IN_URL,
 		NO_SIGNATURE_KEY_IN_URL,
 		NO_SIGNATURE_VALUE_IN_URL,
 		INVALID_SIGNATURE,