Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usermod BME280: Fix "Unit of Measurement" for temperature #4360

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

euphi
Copy link

@euphi euphi commented Dec 7, 2024

The Unit of Measurement ("tempScale") of the MQTT message is set for each published measurement - but not for the homeassistant discovery.

Thus, openhab (and mabye other systems?) don't recognize the value as "Number" - so it uses String instead. This is somehow annoying when trying to configure the sensor channel to be linked to an existing item in OpenHAB. (Items that are created automatically or with "Add point to model" can be configured in a way that the String is transformed to Number or Number:Temperature, but existing Items cannot be linked).

When a "Unit of Measurement" is set in HomeAssistant discovery, the HA binding of OpenHAB notices that the MQTT String is a number and automatically converts it.

See also openhab/openhab-addons#6663 .

The Unit of Measurement ("tempScale") of the MQTT message is set for each published measurement - but not for the homeassistant discovery.

Thus, openhab (and mabye other systems?) don't recognize the value as "Number" - so it uses String instead. This is somehow annoying when trying to configure the sensor channel to be linked to an existing item in OpenHAB.
(Items that are created automatically or with "Add point to model" can be configured in a way that the String is transformed to Number or Number:Temperature, but existing Items cannot be linked).

When a "Unit of Measurement" is set in HomeAssistant discovery, the HA binding of OpenHAB notices that the MQTT String is a number and automatically converts it.
@euphi
Copy link
Author

euphi commented Dec 7, 2024

MQTT Message on homeassistant/sensor/WLED-Ian-Tray/Temperature/config

Before Change:

{
  "name": "WLED Ian Tray Temperature",
  "state_topic": "wled/ian-tray/temperature",
  "unique_id": "WLED-Ian-TrayTemperature",
  "device_class": "temperature",
  "expire_after": 1800,
  "device": {
    "name": "WLED Ian Tray",
    "identifiers": "wled-sensor-WLED-Ian-Tray",
    "manufacturer": "WLED",
    "model": "FOSS",
    "sw_version": "0.15.0-rc1"
  }
}

After Change:

{
  "name": "WLED Ian Tray Temperature",
  "state_topic": "wled/ian-tray/temperature",
  "unique_id": "WLED-Ian-TrayTemperature",
  "unit_of_measurement": "°C",
  "device_class": "temperature",
  "expire_after": 1800,
  "device": {
    "name": "WLED Ian Tray",
    "identifiers": "wled-sensor-WLED-Ian-Tray",
    "manufacturer": "WLED",
    "model": "FOSS",
    "sw_version": "0.15.0-rc1"
  }
}

@euphi euphi changed the title Fix "Unit of Measurement" for BME280 temperature Usermod BME280: Fix "Unit of Measurement" for temperature Dec 7, 2024
@DedeHai
Copy link
Collaborator

DedeHai commented Dec 9, 2024

I neither use MQTT nor the BME280 mod, but seems like a valueable addition to me.

@netmindz netmindz changed the base branch from 0_15_0 to 0_15 December 10, 2024 08:04
@netmindz netmindz changed the base branch from 0_15 to 0_15_0 December 10, 2024 08:05
@netmindz netmindz merged commit d7bebc2 into Aircoookie:0_15_0 Dec 10, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants