Limit number of LEDS shown in Liveview to pixel width of canvas #3696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids aliasing errors on narrow screens (such as on mobile). Follow-on to discussion in Aircoookie#3621 , but broken out into a separate pull request.
|
Removing a part of LED strip from peek would be more annoying than seeing moire. |
|
Fair enough. I'll open another PR for another method to reduce moire without cutting off the end. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids aliasing errors on narrow screens (such as on mobile). Follow-on to discussion in #3621 , but broken out into a separate pull request.
For example, when displaying the colors from the C9 palette:
The current 0_15 branch code looks like the following with 1024 LEDs on a mobile screen that's 915 pixels wide:
Limiting it to the width of the canvas results in the following:
