Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tetris AI #3626

Closed
wants to merge 3 commits into from
Closed

Tetris AI #3626

wants to merge 3 commits into from

Conversation

muebau
Copy link
Contributor

@muebau muebau commented Dec 29, 2023

Adds an self playing Tetris effect based on a simple AI (polynomial).

@softhack007 softhack007 added effect usermod usermod related labels Jan 10, 2024
@blazoncek
Copy link
Collaborator

Thank you.
You will need to rebase this to 0_15 branch.

@muebau
Copy link
Contributor Author

muebau commented Jan 15, 2024

;-) sounds good. I know how to do it with git at the command line but I have no clue how to get it in Github. Do you have a hint for me?

@blazoncek
Copy link
Collaborator

Do it locally (checkout upstream/0_15, checkout your branch (not main!!!), merge 0_15 into your branch, push).
Please follow https://github.com/Aircoookie/WLED/wiki/How-to-properly-submit-a-PR

@muebau
Copy link
Contributor Author

muebau commented Jan 15, 2024

Thank you. By "your branch (not main!!!)" you mean "muebau/main"? (as I developed my mod at this branch)

If not, should I create a branch like muebau/tetris?

@blazoncek
Copy link
Collaborator

Thank you. By "your branch (not main!!!)" you mean "muebau/main"? (as I developed my mod at this branch)

If not, should I create a branch like muebau/tetris?

You should have not.

Yes, make a new branch and PR from that. As described in the article.

@muebau
Copy link
Contributor Author

muebau commented Jan 21, 2024

Sorry for the delay. It has been a busy week.
I did like you told me. I think it should be better now.

#3711

@blazoncek
Copy link
Collaborator

Closed in favour of #3711

@blazoncek blazoncek closed this Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effect usermod usermod related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants