-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Usermod: httpPullLightControl v0.0.5 (supersede v0.0.4) #3560
Usermod: httpPullLightControl v0.0.5 (supersede v0.0.4) #3560
Conversation
Show 2D Configuration button by default
Fix wrong power supply info
Add LDR sensor dusk/dawn preset control Usermod
By adding a random string to the path of the js file every time, we make sure to never hit the browser cache.
By setting the response header "Cache-Control" to "no-store" and setting "Expires" to 0, we make sure the browsers and place calling this never store it in cache.
This reverts commit 51dfa9a.
Fix settings caching on some browsers
Fix repeatable action for ir json
* purge old (not yet processes) NTP responses * validate server responses before updating WLED time * purge receive buffer when package is rejected (avoids mem leak on esp32)
when NTP got enabled via UI, WLED would wait up to 12 hours before issuing the first NTP request.
This one supersede #3527 |
Hi,
It seems you always create a new PR when updating your code? Its simpler for us maintainers if you use the same PR, and simply add commits when necessary. Cheers, Frank. |
Excuse, I thought (according to the docs: https://github.com/Aircoookie/WLED/wiki/How-to-properly-submit-a-PR ) that I needed to do a PR with only ‘1 commit with all of the merged changes’. However v0.0.5 is quite solid now. We did a lot of testing and more than 60 units are running it over the world :) If there will be a new v0.0.6 in let’s say 1 year from now, do you want me to do that in a PR then? |
Guidelines are there for 1st submission. If changes are requested or bugs are found or new features are added there is no need to open a new PR, just push new commits to the branch used for PR. PR will be updated accordingly. |
Fix for UCS8904 hasWhite().
I've found a code spellchecker, so this is what can be corrected easily. Changes are only affecting comments, readme and a few user-visible strings. So no functional impact expected.
if you can spell Fahrenheit, you can't spell Celsius. And vice versa :-)
obuf is reset to nullptr in some cases
PHST abbreviation added for clarity.
According to the technical manual, GPIO 16 + 17 are used for onboard flash, so cannot be used by WLED. example buildenv: [env:esp32_pico] extends = env:esp32dev_qio80 board = pico32
refreshing all UI files
Please update PR (pull, fix, push) and rebase to 0_14_2 branch. |
I just did, it is now up-to-date with the WLED/main, which is 0_14_2. Can you accept this pull request so it will be really IN there? I already had to fix a merge-conflict because of a Dusk_Dawn usermod which was having Usermod_ID 43 (and we had it also). So moved them to 44. |
Some changes after extensive testing. Now it will not break the runtime of WLED when there is invalid JSON.