Merge pull request #3893 from Aircloak/sebastian/datasource-definitio…

…n-error-fix

Do not warn on differing data sources due to incomplete bounds

air/lib/air/service/cloak.ex

@@ -167,14 +167,15 @@ defmodule Air.Service.Cloak do
       |> Lens.to_list(datasource_tables)
       |> Enum.empty?()
 
-  defp pending?(column), do: column[:shadow_table] == :pending or column[:isolated] == :pending
+  defp pending?(column),
+    do: column[:shadow_table] == :pending or column[:isolated] == :pending or column[:bounds] == :pending
 
   defp strip_tables_of_temporary_state(tables),
     do:
       Lens.all()
       |> Lens.key(:columns)
       |> Lens.all()
-      |> Lens.map(tables, &Map.drop(&1, [:isolated, :shadow_table, :shadow_table_size]))
+      |> Lens.map(tables, &Map.drop(&1, [:isolated, :shadow_table, :shadow_table_size, :bounds]))
 
   defp add_error_on_different_salts(data_sources, cloak_info) do
     for data_source <- data_sources do

air/test/air/service/cloak_test.exs

@@ -90,6 +90,38 @@ defmodule Air.Service.Cloak.Test do
     assert error =~ ~r/differs between .+ cloaks/
   end
 
+  test "should not record differences in bounds stats when not all data sources done" do
+    data_sources_done = [data_source_with_columns()]
+
+    data_sources_pending = [
+      data_source_with_columns([
+        table_column(%{bounds: :pending})
+      ])
+    ]
+
+    Cloak.register(TestRepoHelper.cloak_info(), data_sources_pending)
+    Cloak.register(TestRepoHelper.cloak_info("other_cloak"), data_sources_done)
+    assert [] == Jason.decode!(Repo.get_by!(DataSource, name: @data_source_name).errors)
+  end
+
+  test "should record differences in bounds stats when all data sources done" do
+    data_sources_done1 = [
+      data_source_with_columns([
+        table_column(%{bounds: :ok})
+      ])
+    ]
+
+    data_sources_done2 = [
+      data_source_with_columns([
+        table_column(%{bounds: :failed})
+      ])
+    ]
+
+    Cloak.register(TestRepoHelper.cloak_info(), data_sources_done1)
+    Cloak.register(TestRepoHelper.cloak_info("other_cloak"), data_sources_done2)
+    refute [] == Jason.decode!(Repo.get_by!(DataSource, name: @data_source_name).errors)
+  end
+
   test "should not record differences in isolating stats when not all data sources done" do
     data_sources_done = [data_source_with_columns()]
 
@@ -213,6 +245,7 @@ defmodule Air.Service.Cloak.Test do
   defp table_column(params \\ %{}) do
     Map.merge(
       %{
+        bounds: :ok,
         isolated: true,
         name: "column_name",
         shadow_table: :ok,