feat: let user tweak architect prompt before passing to editor-model

[gitkenan]

closes issue 3085 : #3085 (comment)

This is just a demonstration for those who want to test it out... despite there being room for improvement, I use this happily in my local setup I thought I'd share it in case anyone wants to use it.

There is something I'm not 100% sure of yet: the intended design is that the resulting context doesn't contain any 'old content' from the architecture model's first try. The context should only contain the manually edited architectural prompt to then hand over to the editor model. In theory this is what my PR does but I'm not familiar enough with Aider to test it.

Another thing I did here is that I have cleaned up how the kwargs dictionary was being initiated, and deleted an unused 'validate' function.

I should also note that I haven't ran pytest for this change. Finally, I haven't given the option for users to configure which editor they want to use, so this is also a to-do for this feature, however they can over-ride this by setting EDITOR in their ~/.bashrc or ~/.zshrc file.

Any comments are appreciated!

[CLAassistant]

All committers have signed the CLA.

[hellno]

love this approach. I run into this every day. I want changes A and D as architecture model suggest. I want to remove change B and adjust change C. very clumsy flow in aider.

Finally, I haven't given the option for users to configure which editor they want to use, so this is also a to-do for this feature.

I would separate this into a different PR. seems related but not a requirement for this change.

[gitkenan]

love this approach. I run into this every day. I want changes A and D as architecture model suggest. I want to remove change B and adjust change C. very clumsy flow in aider.

Finally, I haven't given the option for users to configure which editor they want to use, so this is also a to-do for this feature.

I would separate this into a different PR. seems related but not a requirement for this change.

Thank you for the very nice comment, I'm glad you find it useful! I've just updated the PR to try to amend some documentation components of the architect model.

[gitkenan]

I may have introduced a bug when you forget to add a file in architect mode. After confirming you want to add the file, it seemed to hang. Investigating...

[gitkenan]

I may have introduced a bug when you forget to add a file in architect mode. After confirming you want to add the file, it seemed to hang. Investigating...

I can confirm that I was wrong about this bug, I've tested it again and it's working fine.