-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add --map-cache-dir to change the base directory for .aider.tags.cache.v3 #2911
base: main
Are you sure you want to change the base?
Conversation
So this is the directory where the map cache DB is stored? might want to make the command more explicit to avoid confusion with the root of the repository map itself, e.g. due to |
Yes, you are right @Finndersen, it's the directory where the repomap cache .aider.tags.cache.v3 is located and has nothing to do with the repository itself. The option is related to an existing option group Repomap settings. So I'm fine with --map-root in this context, but if you have a better name for the option, let me know... |
Maybe something like |
Changed the argument name according to a suggestions from @Finndersen to less ambiguous --map-cache-dir |
…ing conventions in base_coder.py and repomap.py
@coredevorg i still think |
Sorry for the confusion, @Finndersen. Unfortunately it's not just the name of the argument in args.py and main.py but the variable is used via **kwargs in the other modules. My quick-and-dirty hack to change the name of the argument has broken the patch so I have to revert because I need the patched aider in my environment. If you really want to change the name, it needs a more in depth refactoring and testing. I won't be able to take a closer look at it for at least 2 weeks. And, btw, it's really the root directory for the cache subdirectory .aider.tags.cache.v3 containing the cache.db. |
Ok, well I still think the user interface/API design should probably be priority. Would |
The patch makes the root directory for
.aider.tags.cache.v3
configurable through an additional argument--map-root
orAIDER_MAP_ROOT
environment variable.This becomes important if your project lives on a CIFS mount and you encounter:
With the
--map-root
parameter, the cache directory can be moved to local device to avoid the problem.