-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: provision wallet notice dialog #99
Conversation
@samsiegart what do you mean by 'shows the dialog before signing the transaction'? Do you mean the dialog will appear to the user when they land on the dapp before they attempt the wallet spend action i.e. 'Create vault'? or do you mean it appears right after they hit 'create vault' but before txn is signed? |
@otoole-brendan When you click the "make offer" button the dialog will pop up if there's no smart wallet, otherwise it just goes straight to keplr. |
Deploying ui-kit with
|
Latest commit: |
2adac06
|
Status: | ✅ Deploy successful! |
Preview URL: | https://dd62859a.ui-kit-dwm.pages.dev |
Branch Preview URL: | https://provision-dialog-2.ui-kit-dwm.pages.dev |
3451634
to
15c0a93
Compare
@ivanlei I know you mentioned before |
That's my vote. |
Made the provision dialog the default |
fixes #78
Adds a function
checkSmartWalletProvisionAndMakeOffer
which will automatically show the provision wallet notice before attempting to sign the offer.Builds upon #98 to provide the "Deposit IST" button with leap elements.
Testing
Tested with dapp-offer-up in Agoric/dapp-offer-up@f0c2f73 (using
yarn link @agoric/react-components
). Simply replacedmakeOffer
withcheckSmartWalletProvisionAndMakeOffer
and now it shows the dialog before signing the transaction.Screenshot