feat(patches): patch in endo #2377 #9762
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
|
|
Converted to Draft until endojs/endo#2377 settles down. But still adequate for performance testing the difference! |
Deploying agoric-sdk with
|
| Latest commit: |
5453d2a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://53879de3.agoric-sdk.pages.dev |
| Branch Preview URL: | https://markm-patch-in-endo-2377.agoric-sdk.pages.dev |
|
Updated to the merged state of endojs/endo#2377 , and so ready for review. |
|
Closing as subsumed by recent agoric-sdk-endo-sync |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patches in endojs/endo#2377 "feat(import-bundle): accept symbol-named properties on inescapableGlobalProperties"
closes: #XXXX
refs: endojs/endo#2377 #9431 #8051 endojs/endo#1676 #9431
Description
Before this and related PRs, the
passStyleOfcreated by the@endo/pass-stylepackage as bundled in contracts was using theglobalThis.WeakMapit found on its global to build its memo table. Under liveslots, this was the Virtual Object Aware WeakMap, which caused a cumulative leak.To fix this, endojs/endo#1676 changed
@endo/pass-styleto look for a symbol-named property to serve as the endowedpassStyleOf. #9431 on #8051 change liveslots to provide that endowment -- its ownpassStyleOfmade with the primordial non-leakyWeakMap. The remaining piece is endojs/endo#2377 , which modifies@endo/import-bundleto pass through such symbol-named endowment properties. To get ahead of the next endo-release-agoric-sdk-sync cycle, this PR temporarily patches endojs/endo#2377 until then, so we can test and use the performance difference immediately.Security Considerations
none
Scaling Considerations
The point. By itself none, but enables #9431 , which should cure that memory leak.
Documentation Considerations
For this temporary patch PR, none
Testing Considerations
Enables us to test the performance difference #9431 would make.
Upgrade Considerations
See endojs/endo#2377