Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: prune out-date node version in favor of LTS #9031

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Conversation

dckc
Copy link
Member

@dckc dckc commented Mar 4, 2024

Description

prune out-date node version in favor of LTS

Security / Scaling / Testing Considerations

n/a

Documentation / Testing / Upgrade Considerations

I think "we support node LTS" is our goal. Due to issues such as #8599, docs on Platform Requirements currently cite v18.16.0 specifically. In that case, @kbennett2000 regularly tests the getting started docs to be sure it works. I don't think we have a corresponding maintenance trigger for CONTRIBUTING, so "LTS" is probably better.

ci tests 18.x and 20.x, which are the 2 current LTS versions according to the node release schedule:

      matrix:
        node-version: ['18.x', '20.x']

-- https://github.com/Agoric/agoric-sdk/blob/master/.github/workflows/test-all-packages.yml

Copy link
Member

@turadg turadg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dckc dckc added the automerge:rebase Automatically rebase updates, then merge label Mar 13, 2024
@mergify mergify bot merged commit ab31b43 into master Mar 13, 2024
66 checks passed
@mergify mergify bot deleted the dc-node-ver branch March 13, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:rebase Automatically rebase updates, then merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants