Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: forgot to push this in #2037 #2044

Merged
merged 1 commit into from
Nov 21, 2020
Merged

Conversation

erights
Copy link
Member

@erights erights commented Nov 20, 2020

The change I made to resolve @michaelfig 's review comment at #2037 (review) is one I forgot to push in that PR. Here it is.

@erights erights requested a review from michaelfig November 20, 2020 22:52
@erights
Copy link
Member Author

erights commented Nov 21, 2020

@michaelfig @tyg @katelynsills I'm failing a doc test that seems unrelated. Is this because I'm on the hackathon branch? Should I just ignore?

@katelynsills
Copy link
Contributor

@michaelfig @tyg @katelynsills I'm failing a doc test that seems unrelated. Is this because I'm on the hackathon branch? Should I just ignore?

It looks like this is caused by the documentation repo looking for the latest call spread changes that @Chris-Hibbert put in, but not finding them in the hackathon branch. I don't think @Chris-Hibbert was expecting to port those changes over to the hackathon branch, so I think you can ignore for now.

@erights erights requested a review from katelynsills November 21, 2020 02:48
Copy link
Contributor

@katelynsills katelynsills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@erights erights merged commit 7aedb3f into hackathon-2020-11 Nov 21, 2020
@erights erights deleted the push-omitted-correction branch November 21, 2020 03:03
erights added a commit that referenced this pull request Dec 12, 2020
erights added a commit that referenced this pull request Dec 12, 2020
erights added a commit that referenced this pull request Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants