support changes to governed APIs #10822
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chris-Hibbert
force-pushed
the
9990-upgradeAPIs
branch
from
cc5512a to
4d3a323
Compare
Deploying agoric-sdk with
|
| Latest commit: |
1dc3e9a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e5c2adda.agoric-sdk.pages.dev |
| Branch Preview URL: | https://9990-upgradeapis.agoric-sdk.pages.dev |
Chris-Hibbert
force-pushed
the
9990-upgradeAPIs
branch
from
4d3a323 to
1dc3e9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #9990
Description
When a contract is upgraded, we'll read the governed APIs afresh.
Security Considerations
Nothing special. The point of governed APIs is that contracts can make access to calling specific APIs legible in the sense used by governance.
Scaling Considerations
Not an issue.
Documentation Considerations
If we had detailed documentation on governance, this would be worth adding to the docs.
Testing Considerations
Added a bootstrap test showing that a contract can be upgraded and the new APIs will be available after upgrade.
Upgrade Considerations
No existing contracts are using governed APIs. When they are added, the contract will use the latest version of the governance code, and upgrade will work.