Semantic versioning #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevesims
commented
Oct 25, 2023
src/version.h
Outdated
Comment on lines
4
to
8
| #define VERSION_MAJOR 2 | ||
| #define VERSION_MINOR 0 | ||
| #define VERSION_PATCH 0 | ||
| #define VERSION_CANDIDATE 1 // Optional | ||
| #define VERSION_TYPE "Alpha " // RC, Alpha, Beta, etc. |
There was a problem hiding this comment.
version here is a placeholder...
arguably this could just reflect the previous 1.4 version.
given that we have added a bunch of new commands, a 1.5 base version may be justified. similarly it is likely that we will add in the perf PR soon too, which also justifies at least a minor version bump
the alternative argument is that we're moving to a different versioning system, and that is enough to justify a major version bump
move version info out to `version.h` file version info now a semantic version, with major, minor, patch, and “candidate” info, as well as an indicator for candidate type (displayed if candidate number is non-zero) support for showing an automatically-generated build number added, which can be provided by a build script and is intended to be derived from the git hash with this approach it should also be possible in the future to add other tooling to automatically increment version numbers version info also includes the codebase variant, allowing us to easily differentiate between Quark and Console8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move version info out to
version.hfileversion info now a semantic version, with major, minor, patch, and “candidate” info, as well as an indicator for candidate type (displayed if candidate number is non-zero)
support for showing an automatically-generated build number added, which can be provided by a build script and is intended to be derived from the git hash
with this approach it should also be possible in the future to add other tooling to automatically increment version numbers
version info also includes the codebase variant, allowing us to easily differentiate between Quark and Console8