Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use recommended solhint rules #212

Merged
merged 2 commits into from
Sep 20, 2022
Merged

Use recommended solhint rules #212

merged 2 commits into from
Sep 20, 2022

Conversation

larryob
Copy link
Contributor

@larryob larryob commented Sep 20, 2022

No description provided.

@github-actions
Copy link

LCOV of commit a626439 during Smart Contracts PR Workflow #531

Summary coverage rate:
  lines......: 76.9% (674 of 876 lines)
  functions..: 61.5% (128 of 208 functions)
  branches...: 67.5% (166 of 246 branches)

Files changed coverage rate:
                                           |Lines       |Functions  |Branches    
  Filename                                 |Rate     Num|Rate    Num|Rate     Num
  ===============================================================================
  src/ethereum/L1CompoundStrategy.sol      |75.9%     54|60.0%    15|45.0%     20
  src/ethereum/L1WormholeRouter.sol        |83.3%     30| 100%     5|75.0%     16
  src/external/Multicall.sol               |55.6%      9| 100%     1| 0.0%      4
  src/polygon/EmergencyWithdrawalQueue.sol | 100%     35| 100%     6|64.3%     14
  src/polygon/L2AAVEStrategy.sol           |67.3%     49|57.1%    14|37.5%     16
  src/polygon/L2Vault.sol                  |83.0%    171|68.2%    44|78.0%     50
  src/polygon/L2WormholeRouter.sol         | 100%     30| 100%     5|75.0%     16
  src/test/Wormhole.t.sol                  | 100%      1| 100%     1|    -      0

@larryob
Copy link
Contributor Author

larryob commented Sep 20, 2022

Tests failing because of this: foundry-rs/foundry#3227

@github-actions
Copy link

LCOV of commit 89a5c16 during Smart Contracts PR Workflow #532

Summary coverage rate:
  lines......: 77.1% (683 of 886 lines)
  functions..: 61.7% (129 of 209 functions)
  branches...: 67.2% (168 of 250 branches)

Files changed coverage rate:
                                           |Lines       |Functions  |Branches    
  Filename                                 |Rate     Num|Rate    Num|Rate     Num
  ===============================================================================
  src/ethereum/L1CompoundStrategy.sol      |75.9%     54|60.0%    15|45.0%     20
  src/ethereum/L1WormholeRouter.sol        |83.3%     30| 100%     5|75.0%     16
  src/external/Multicall.sol               |55.6%      9| 100%     1| 0.0%      4
  src/polygon/EmergencyWithdrawalQueue.sol | 100%     35| 100%     6|64.3%     14
  src/polygon/L2AAVEStrategy.sol           |67.3%     49|57.1%    14|37.5%     16
  src/polygon/L2Vault.sol                  |83.0%    171|68.2%    44|78.0%     50
  src/polygon/L2WormholeRouter.sol         | 100%     30| 100%     5|75.0%     16
  src/test/Wormhole.t.sol                  | 100%      1| 100%     1|    -      0

@larryob larryob merged commit dc66ce7 into master Sep 20, 2022
@larryob larryob deleted the solhint-recommended branch September 20, 2022 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant