You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
With the traits approach, we have a bunch of #[doc(hidden)] pub struct Foo going on, and we have a lot of duplication of methods that shouldn't really be necessary. If we can consolidate this into a large enum, we'll be able to get rid of a lot of this; however, this would mean that the library is no longer easily extensible. I'll have to put some thought into what to do here, but it's a "later" type of issue either way.
The text was updated successfully, but these errors were encountered:
Move everything into payload structs and use a trait to combine it all.
Closes#3.
We should investigate moving from traits to enums in the future (#5).
With the traits approach, we have a bunch of
#[doc(hidden)] pub struct Foo
going on, and we have a lot of duplication of methods that shouldn't really be necessary. If we can consolidate this into a large enum, we'll be able to get rid of a lot of this; however, this would mean that the library is no longer easily extensible. I'll have to put some thought into what to do here, but it's a "later" type of issue either way.The text was updated successfully, but these errors were encountered: