Improve deserialization unit testing #1421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kwok-he-Chu
reviewed
Jan 24, 2025
|
|
||
| PaymentRequest parsedCheckoutPaymentRequest = PaymentRequest.fromJson(paymentRequestJson); | ||
| assertNotNull(parsedCheckoutPaymentRequest.getPaymentMethod()); | ||
| assertEquals(CardDetails.TypeEnum.SCHEME, parsedCheckoutPaymentRequest.getPaymentMethod().getCardDetails().getType()); |
There was a problem hiding this comment.
Improvement: Let's assert that all properties are populated correctly after deserialization, not just SCHEME but also encryptedExpiryMonth etc. (see paymentRequestScheme.json mock)
| paymentRequest.setReturnUrl("http://return.com"); | ||
| paymentRequest.setPaymentMethod(new CheckoutPaymentMethod(idealDetails)); | ||
| public void TestDeserializePaymentRequestIdeal() throws Exception { | ||
| String paymentRequestJson = getFileContents("mocks/checkout/paymentRequestIdeal.json"); | ||
|
|
||
| PaymentRequest parsedCheckoutPaymentRequest = PaymentRequest.fromJson(paymentRequestJson); | ||
| assertEquals(IdealDetails.TypeEnum.IDEAL, parsedCheckoutPaymentRequest.getPaymentMethod().getIdealDetails().getType()); |
There was a problem hiding this comment.
Improvement: idem. see comment below
|
Kwok-he-Chu
approved these changes
Jan 24, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to:
schemeTestDeserializePaymentRequestIdeal)