Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor TestDonationsSuccessCall #1221

Closed
wants to merge 2 commits into from

Conversation

DjoykeAbyah
Copy link
Contributor

Description

Refactor payment method type in TestDonationsSuccessCall test

Updated the paymentMethod type in the TestDonationsSuccessCall test to use the CardDonations class instead of CardDetails.

Changes Made:
Replaced CardDetails with CardDonations as the payment method type.

Testing:
Ran the tests with exit code 0 as return

@DjoykeAbyah DjoykeAbyah requested a review from a team as a code owner January 12, 2024 17:37
@jillingk
Copy link
Contributor

Let's merge this into #1206 instead of main to have some visibility on your changes :)

@wboereboom wboereboom changed the base branch from main to sdk-automation/models January 15, 2024 07:25
wboereboom
wboereboom previously approved these changes Jan 15, 2024
@wboereboom
Copy link
Contributor

I updated the target branch. changes are properly reflected now.

jillingk
jillingk previously approved these changes Jan 15, 2024
@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/models branch 2 times, most recently from f338507 to ea01f7d Compare January 16, 2024 19:29
@jillingk jillingk changed the base branch from sdk-automation/models to main January 17, 2024 08:39
@jillingk jillingk dismissed stale reviews from wboereboom and themself January 17, 2024 08:39

The base branch was changed.

@jillingk jillingk changed the base branch from main to sdk-automation/models January 17, 2024 08:39
@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/models branch 2 times, most recently from 1ee6b41 to 464df9a Compare January 22, 2024 08:36
@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/models branch 3 times, most recently from 99f6cc8 to 0a7eac2 Compare January 26, 2024 15:17
@AlexandrosMor
Copy link
Contributor

We are going to fix that in the automation sdk pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants