Swap HMAC Validation method parameters #1185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aleffio
reviewed
Nov 23, 2023
Co-authored-by: Alessio Zampatti <alessio.zampatti@adyen.com>
Co-authored-by: Alessio Zampatti <alessio.zampatti@adyen.com>
Aleffio
approved these changes
Nov 24, 2023
michaelpaul
approved these changes
Nov 24, 2023
wboereboom
added
Breaking change
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The HMAC Validation method on the Java library is showing the
hmacKeyand thehmacSignatureswapped.The merchants/partners can still use the method by swapping the two, but it is confusing as they actually have to look at the source code to figure it out.
This pr swaps the two parameters, and add comments to explain the usage.
Tested scenarios
Tests are passing