Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove network-online.target as a systemd-service dependency for the sake of boot time? #739

Closed
kevinywlui opened this issue Jul 16, 2024 · 2 comments

Comments

@kevinywlui
Copy link

Fill out information requested in this template, without doing so issue will be ignored & closed!

Have you tried?

Yes. I tried to keyword match against network.target network-online.target

Error output:

$ systemd-analyze critical-chain       
The time when unit became active or started is printed after the "@" character.
The time the unit took to start is printed after the "+" character.

graphical.target @10.655s
└─multi-user.target @10.655s
  └─auto-cpufreq.service @10.655s
    └─network-online.target @10.654s
      └─NetworkManager-wait-online.service @2.523s +8.129s
        └─NetworkManager.service @2.182s +337ms
          └─basic.target @2.180s
            └─dbus-broker.service @2.152s +24ms
...

System information:

Add/paste output of:

auto-cpufreq --debug

Skipped this since this seem unrelated to the core issue.

Also please be descriptive about the issue you're reporting, i.e: what you tried & what's the expected behaviour.


The main question of this Issue is whether we can remove the dependency from auto-cpufreq.service onto network-online.target. This systemd target blocks until network connectivity which can take several seconds. I do not believe auto-cpufreq uses the network so I believe this dependency can be removed. The blame history points at 84e0c6c but I didn't find additional information.

@AdnanHodzic
Copy link
Owner

AdnanHodzic commented Jul 17, 2024

. I do not believe auto-cpufreq uses the network so I believe this dependency can be removed.

I would agree with you on this one, as I can't remember why exactly was this change made.

I do not believe auto-cpufreq uses the network so I believe this dependency can be removed. The blame history points at 84e0c6c but I didn't find additional information.

I would encourage you to give it a try and contribute to the project and you will be credited for your work as part of future release.

@AdnanHodzic
Copy link
Owner

@kevinywlui I just pushed changes which remove network-online.target as a systemd-service in order to increase boot time.

shadeyg56 added a commit that referenced this issue Aug 5, 2024
* added the abilty to ignore certain power supplies

* changed config file for ignoring power supplies

* updated exapmle config file for ignoring power supplies

* updated docs with ignoring power supplies

* Update README.md

Update image URL's

* Add support for setting "Platform Profile" (#752)

* Add support for setting "Platform Profile"

* Add reference for Platform Profile

* Fix unsafe access to PATH (#756)

* Fix unsafe access to PATH

* Fix leading separator if PATH is empty

* Unpin psutil and requests (#759)

* Remove network-online.target as a systemd-service dependency (improve boot time). Closes: #739

* minor grammer correction.

* removed wonky file

---------

Co-authored-by: Adnan Hodzic <adnan@hodzic.org>
Co-authored-by: Harsh Panchal <BOOTMGR@users.noreply.github.com>
Co-authored-by: BowDown097 <42720004+BowDown097@users.noreply.github.com>
Co-authored-by: shadeyg56 <31134255+shadeyg56@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants