Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modularize the app #8

Merged
merged 20 commits into from
Feb 16, 2024
Merged

Modularize the app #8

merged 20 commits into from
Feb 16, 2024

Conversation

cyril-marpaud
Copy link
Contributor

Hay =)
Chopped it into small pieces today, along with a few minor improvements.
Let me know if you like it !

Copy link
Owner

@AdinAck AdinAck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great work once again. I only have a couple nitpicks.

src/init.rs Outdated Show resolved Hide resolved
src/error.rs Outdated Show resolved Hide resolved
Copy link
Owner

@AdinAck AdinAck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AdinAck AdinAck merged commit 4a738bd into AdinAck:main Feb 16, 2024
1 check passed
@AdinAck
Copy link
Owner

AdinAck commented Feb 16, 2024

I'd say all of this is worthy of a new crates.io release, wouldn't you? ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants