Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#371 update modified time #372

Merged
merged 12 commits into from
Jul 11, 2024
Merged

#371 update modified time #372

merged 12 commits into from
Jul 11, 2024

Conversation

jellizaveta
Copy link
Contributor

@jellizaveta jellizaveta commented Jul 9, 2024

#371

AG-29349

@jellizaveta jellizaveta requested review from Alex-302 and zhelvis July 9, 2024 17:12
@jellizaveta
Copy link
Contributor Author

I have a few questions:

  1. Can I remove all modified_time keys from source/vpn_services.json so that no one has to enter them manually and leave them only in dist/vpn_services.json (because they were forgotten to be filled in during changes anyway)?
  2. Date format, can we keep it in ISOstring or timestamp so that we don't format the date?

@jellizaveta jellizaveta requested a review from Danila-Arg July 9, 2024 17:28
@Alex-302 Alex-302 requested a review from atropnikov July 10, 2024 10:27
@jellizaveta jellizaveta changed the title #371 update modified time [WIP] #371 update modified time Jul 10, 2024
@jellizaveta jellizaveta marked this pull request as draft July 10, 2024 14:33
@jellizaveta jellizaveta marked this pull request as ready for review July 11, 2024 08:49
@jellizaveta jellizaveta changed the title [WIP] #371 update modified time #371 update modified time Jul 11, 2024
@jellizaveta jellizaveta merged commit 9a6788c into main Jul 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants