Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #142875 www.imdb.com #142876

Merged
merged 7 commits into from
Feb 15, 2023
Merged

Fix #142875 www.imdb.com #142876

merged 7 commits into from
Feb 15, 2023

Conversation

rakleed
Copy link
Contributor

@rakleed rakleed commented Feb 14, 2023

#142875

Now only pop-up is blocked, which automatically appears (without a user request). That is, I solved the problems that were reported in #141159

@rakleed
Copy link
Contributor Author

rakleed commented Feb 14, 2023

@zloyden

@zloyden zloyden added the A: In progress Work on the issue is in progress label Feb 15, 2023
rakleed and others added 2 commits February 15, 2023 15:02
Co-authored-by: krystian3w <35370833+krystian3w@users.noreply.github.com>
@rakleed
Copy link
Contributor Author

rakleed commented Feb 15, 2023

@zloyden @AdamWr to reproduce, follow the link https://hostigram.xyz/?tkn=ZHPyrVjxQXxsl7vifxMYNoVyA1p4yLB9F6NrNYzAW5IwT&dl=1 (and click Download if necessary) to view the saved page. Don't forget to add the hostigram.xyz domain to the rules.

Copy link
Contributor

@zloyden zloyden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#142876 (comment) I've seen that the rules work there, but it's better to test them on imdb.com.
The only option I can suggest is to move the rules to AdGuard Experimental and test them for some time.

@rakleed
Copy link
Contributor Author

rakleed commented Feb 15, 2023

In general, if you are logged into IMDb and go to the page of one movie/TV show every couple of hours, then this window appears at 4-5 opening, which annoys me as an active user of the site.

@zloyden done.

@zloyden zloyden merged commit 70fc9a8 into AdguardTeam:master Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: In progress Work on the issue is in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants