-
Notifications
You must be signed in to change notification settings - Fork 666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
soft98.ir #126425
soft98.ir #126425
Conversation
I could convert uBO to AdGuard syntax if that's really necessary. |
I get |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a general comment
soft98.ir##+js(acis, document.oncontextmenu)
soft98.ir##[src*="file.soft98.ir"]:upward(3):remove()
=>
soft98.ir#%#//scriptlet("abort-current-inline-script", "document.oncontextmenu")
soft98.ir#$?#[src*="file.soft98.ir"]:upward(3) { remove: true; }
However, a rule for document.oncontextmenu
should be in Annoyances if it's meant to tackle right click issue.
||file.soft98.ir^$all,redirect=nooptext
=> ||file.soft98.ir^$script,xmlhttprequest,redirect=nooptext
(should be this way for uBO too)
soft98.ir##body > :nth-of-type(1):before:style(content: "در صورت دیدن هرگونه مشکل در سایت و یا پیغامی برای غیرفعال کردن افزونه حذف تبلیغات، کافیست به تنظیمات افزونه مسدودسازتان بروید و لیست AdGuard Base و PersianBlocker را بروز کنید." !important; color: #ff0000 !important; visibility: visible; font-size: large !important;)
=>
soft98.ir#$#body > :first-of-type:before { content: "در صورت دیدن هرگونه مشکل در سایت و یا پیغامی برای غیرفعال کردن افزونه حذف تبلیغات، کافیست به تنظیمات افزونه مسدودسازتان بروید و لیست AdGuard Base و PersianBlocker را بروز کنید." !important; color: #ff0000 !important; visibility: visible; font-size: large !important; }
@@||soft98.ir^$ghide
=> @@||soft98.ir^$generichide
@Yuki2718 Doesn't AdGuard translate these uBo syntax to AG compatible syntax internally anyway? |
I'll drop this rule, no longer
Doesn't work. It's supposed to remove the banner at the top like this, but your suggest filter doesn't do that on uBO. |
Then use according request type and corresponding redirect resource, $all is not very good for redirect. |
1x1.gif (and similar) => results in a big white square
Ok, I'll see if $image works. |
@Yuki2718 I can't edit the file. |
What? You can edit whatever file in you branch, right? |
@Yuki2718 Please check if the syntax is acceptable.
|
EnglishFilter/sections/foreign.txt
Outdated
@@ -6459,11 +6459,36 @@ zoomit.ir#$#body[style^="padding-top:"] { padding-top: 0!important; } | |||
zoomit.ir#$#body > .hotMenu[style="top: auto;"] { top: 0!important; } | |||
zoomit.ir#$#body > nav.is-sticky[style="top: 130px;"] { top: 0!important; } | |||
zoomit.ir#%#document.cookie = "BnShowNum=4; path=/;"; | |||
soft98.ir#$#[id^="sidebar"][id*="stick"] > section { opacity: 0 !important; pointer-events: none !important; } | |||
soft98.ir#$#header[id]:has(.row) { remove: true; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use syntax example.com#$?#.ad { remove: true; }
for such rules.
Btw, they cause adb detection.
These rules work fine on my end. A directive is needed to limit platforms.
!#if (!adguard_app_windows && !adguard_app_mac && !adguard_app_android && !adguard_ext_android_cb)
||soft98.ir/engine/modules/antibot/antibot.php
||soft98.ir/engine/ajax/controller.php
||file.soft98.ir^$image,redirect=nooptext
||cdn.hostdl.com^$image,redirect=nooptext
||linkdoni.soft98.ir^
||iranicard.ir^$domain=soft98.ir
||asiatech.ir^$domain=soft98.ir
||sysban.ir^$domain=soft98.ir
||smostafa.ir^$domain=soft98.ir
soft98.ir##.show.fade.tooltip
!#endif
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
they cause adb detection.
This site changes fast, if AdGuard merge my filters slowly they'll become useless.
Our compiler does both, but when you add rules to our filters, they must be written using our syntax. |
|
@zloyden I tried to be compatible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some of your rules directly 1ea38d9, I can't edit your branch.
The latest rules are:
As you can see here, I'm constantly sending PRs and they get merged quickly: |
Not all of them are nedeed.
Why do you need a modifier |
I don't want them to get tricky with popups or redirects. |
I got it, but don't see any popups on my end. |
Disable AdGuard, refresh the page and click on the Amazon banner in the header => it's a popup. The "آسیاتک" banner on the sidebar is also opens as a popup. |
I confirm! These rules work for now. Tested with Ungoogled Chromium v.103.0.5060.134 i s uBlock Origin v.1.42.4. https://i.postimg.cc/Yq0C6Mcs/SssS.png Here it is in the picture, if it gets blocked, the site breaks. But it remains visible anyway - it's not a problem. |
Use: Filters
I'll try to get these merged into AdGuard as well so you don't have to manually use filters. |
Any idea on blocking this? |
Remove all previous filters and use the filters I sent here. If that doesn't help, then disable AdGuard Base filters temporarily and see if it's still like that. |
You said you're using uBlock Origin, if that's the case then remove all of my filters and just update the Quick-Fixes list from uBO settings. The related soft98 issue on uBO issue-tracker: |
I did exactly what you wrote but the result is as I showed it in the picture.
I did exactly what you wrote but the result is as I showed it in the picture. |
@Rusenche Okay I can reproduce using Ungoogled Chromium. |
Address: #126252
Related: uBlockOrigin/uAssets#14278
I'll send pull request everyday to update the filters.
cc @zloyden @Yuki2718