HTTPS/DNS-over-HTTPS/DNS-over-TLS #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ar them out from config
…decodes the certificate
…used by /tls/configure
… the warning over json.
…guration removes ports and certificates
golangcibot
reviewed
Feb 22, 2019
| } | ||
| } | ||
|
|
||
| func validateCertificates(data tlsConfig) tlsConfig { |
There was a problem hiding this comment.
cyclomatic complexity 22 of func validateCertificates is high (> 20) (from gocyclo)
| KeyType string `yaml:"-" json:"key_type,omitempty"` // KeyType is one of RSA or ECDSA | ||
|
|
||
| // is usable? set by validator | ||
| usable bool |
There was a problem hiding this comment.
usable is unused (from structcheck)
Codecov Report
@@ Coverage Diff @@
## master #590 +/- ##
===========================================
- Coverage 61.84% 29.11% -32.74%
===========================================
Files 9 20 +11
Lines 1418 3215 +1797
===========================================
+ Hits 877 936 +59
- Misses 438 2170 +1732
- Partials 103 109 +6
Continue to review full report at Codecov.
|
Print all net interfaces when bind_host is 0.0.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.