Add qq to blocked services

[ifurther]

Add the qq to blocked services

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.75%. Comparing base (dae275e) to head (d7fce74).
Report is 1938 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1775   +/-   ##
=======================================
  Coverage   38.75%   38.75%           
=======================================
  Files          61       61           
  Lines        8220     8220           
=======================================
  Hits         3186     3186           
  Misses       4632     4632           
  Partials      402      402           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[ameshkov]

Bad bot. @ArtemBaskal please take care

[ArtemBaskal]

Merged 32b24ce

[gtaphash]

@ameshkov when block qq.com domain (qq app, mailbox, office suites) then it brake access to wechat.com, localized web browser/ updates browser.qq.com, desktop/security solutions updates guanjia.qq.com and other third-party sites depend on qq.
This blocked service cannot take control over all products or services compared to existing services also leave some applications vulnerable 🤔

[ameshkov]

@gtaphash what do you suggest?

[gtaphash]

@gtaphash what do you suggest?

This may need to limit for im.qq.com (IM app) and mail.qq.com (mailbox) which means by qq but qq.com has local news site otherwise add ⓘ button to explain about possible issues when block it in a network (said browser, desktop/security products mostly use or purchase by local people even might has attraction to qq app)
Generally IM app site, root domain etc available in local language or this service can remove according to one of my opinion and let people to add these type of services via custom blocked services #1692
or Check which domains use for software updates and whitelist them (maybe not a good idea)

[ameshkov]

Well, we could do that I guess, but I think that would be kinda misleading. Offering to block QQ, but not even blocking its homepage is weird.

Let's maybe consider unblocking specifically the domain that breaks wechat.com?

and other third-party sites depend on qq.

Depend in which way? Any examples?

[gtaphash]

Let's maybe consider unblocking specifically the domain that breaks wechat.com?
Depend in which way? Any examples?

Depend on qq.com CNAME and that looks like a kill-switch for brake many (PR user seems come from taiwan, i don't know) 😄

Let's maybe consider unblocking specifically the domain that breaks wechat.com?

Site: weixin.qq.com wx.qq.com(static) dldir1.qq.com(downloads) akm.qq.com(downloads)
other usage: weixin.qq.com imtt.qq.com maybe has other. sign-up stuck from my country (not ISP issue)

Google Play
https://im.qq.com/
QQ - 10 million installs (since 2011 sep release)
https://play.google.com/store/apps/details?id=com.tencent.mobileqq
QQ mail - 1 million installs (since 2013 jan release)
QQ international (english version) - upto 10 thousand installs
(it had removed from google play https://play.google.com/store/apps/details?id=com.tencent.mobileqqi)
This is it - https://apkpure.com/qq-international-chat-call/com.tencent.mobileqqi
Wechat - 100 million installs (since 2011 jan release)

It's much lower than telegram - 500 million installs

Or may be consider 'WeChat' instead?
the site also available in english by default and ago USA wanted to block it

[ameshkov]

Depend on qq.com CNAME and that looks like a kill-switch (PR seems come from taiwan, i don't know) 😄

Oh, this makes sense.

Or isn't it good to add 'WeChat' instead?

I guess we should add an option for WeChat as well.
Maybe Weibo as well? Baidu?

[ameshkov]

Google Play

Well, since Google Play does not work on the mainland, I don't think the numbers from there are reasonable.

Also, the point of "Blocked services" is to allow users quickly disabling this or that service on the per-client basis.
For instance, if you'd like to prevent kids from chatting/playing, you could do that for their devices.

[gtaphash]

Well, since Google Play does not work on the mainland, I don't think the numbers from there are reasonable.

It's about how much certain app popular worldwide and there're so many chinese people use skype(also companies), gmail(even it blocked), hotmail and i clearly know that there also 2-3k members contain chinese groups in telegram (mostly those are not counted). eg: baidu seems just a search engine in chinese language https://www.baidu.com/

Or isn't it good to add 'WeChat' instead?

I guess we should add an option for WeChat as well.

so more, kik, hangouts, imo, hike/jio/indian messenger, viber, icq and others
(actually need to have standard for blocked services) eg: add only dominated services or lack privacy friendly services or add option to select services under particular categories (regardless popular or not)

it's upto you to decide what to do and treat the product. ago i saw qq domain brake software updates, wechat and other sites, that was main reason for add a comment

[Aikatsui]

Above argument reasonable; regional focused apps often has low installation rate even they're accessible around the world.

Past i addressed an issue about add microsoft, amazon, reddit, google, cloudflare, yandex, origin and ignored 1* 4* 6* companies because of their products, adguardhome especially designed for home users (not for enterprises that aware about IT). Amazon partially blocked due their hosting platform and yandex ignored due their web browser (at the moment wasn't aware it has such type messenger then it also a reason) (also same for QQ browser etc and their offline usable tools)

Current blocked services page has 'block all' and 'unblock all' buttons on the top. It means for home users, Oh! let's block these hipop services with just one click

Also, the point of "Blocked services" is to allow users quickly disabling this or that service on the per-client basis.
For instance, if you'd like to prevent kids from chatting/playing, you could do that for their devices.

It is a copy of nextdns #819 i dont think it's appropriate for continuously add every requested services with expectation to achieve its goal.

Then need to implement feature similar below for advanced blocking(for only effect to each category services and cover worldwide solutions) while let to remaining existing blocked services component with custom option #1692, current behavior doesn't make sense. just kids find alternative in next minute that parents never have heard for life ;)

(actually need to have standard for blocked services).... or select services under particular categories

[ameshkov]

(actually need to have standard for blocked services) eg: add only dominated services or lack privacy friendly services or add option to select services under particular categories (regardless popular or not)

The reason for blocking a service may not just be whether it's privacy-friendly or not.

Anyways, I filed a new issue so that we don't forget about that: #2224

@kizunaH

Then need to implement feature similar below for advanced blocking

I kinda agree and disagree at the same time:)

IMO, it's hard for people to realize what actual services are behind these categories. It's just easier to understand what exactly is being blocked when you see the names and the logos.

[Aikatsui]

Also, the point of "Blocked services" is to allow users quickly disabling this or that service on the per-client basis.
For instance, if you'd like to prevent kids from chatting/playing, you could do that for their devices.

I kinda agree and disagree at the same time:)

IMO, it's hard for people to realize what actual services are behind these categories. It's just easier to understand what exactly is being blocked when you see the names and the logos.

Just a comment. let me know if it good to implement and need to open feature request.

I can realize the point of view but this isn't a perfect solution for parental control or access prevention to certain category services at all (belongs to individual/kids/co-workers) unless let users to disable access for dominant internet companies.
The propose new solution will address that properly and adguardhome has lot of users already so they'll definitely help if missing something.

• block youtube but there're dtube, vimeo, rutube...
• block tiktok but there're chingari, dubsmash, triller...

The benefit: Each category will provide most effective coverage. eg: block IM apps then DNS server owner can unblock only the required app for server users to communicate (eg: skype)

About social media:
May be okey to add weibo since far known as chinese social media but i don't recommend to add other regional services. Already has 10M+ adguardhome docker downloads. i dont want see this become one of another source that bring foreigners to regional sites and expand numerous disappointing troubles than today.
(Since this 'blocked services' component come from nextdns and only has facebook in it; later they started to offer special toggle option called 'social media' to cover rest of all services). it's similar above proposed solution

[ameshkov]

What I mean is that ideally, we should allow both: blocking by categories AND/OR blocking a single popular service.

I haven't given this enough thought though.