Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update blocked_services.go Snapchat Rules #1189

Closed
wants to merge 2 commits into from
Closed

Update blocked_services.go Snapchat Rules #1189

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 20, 2019

More Snapchat owned domains

@codecov-io
Copy link

codecov-io commented Nov 20, 2019

Codecov Report

Merging #1189 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1189   +/-   ##
=======================================
  Coverage   30.28%   30.28%           
=======================================
  Files          41       41           
  Lines        6382     6382           
=======================================
  Hits         1933     1933           
  Misses       4187     4187           
  Partials      262      262
Impacted Files Coverage Δ
home/blocked_services.go 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee41c18...77bd22c. Read the comment docs.

@ghost
Copy link

ghost commented Nov 20, 2019

@cybo1927 These domains not required. snapchat-proxy.appspot.com, snapchat-webfonts.storage.googleapis.com, snapnet-cdn.storage.googleapis.com, sc-static.net

You can add below if necessary.

  • snap.com (www.snap.com)
  • sc-cdn.net (block load already signed app account contents)

@ghost
Copy link
Author

ghost commented Nov 20, 2019

Thanks, I was just going off things I've found from Snapchat. (Currently don't have a phone so couldn't check to see what they each did)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant