Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility for wildcards in "ignored domains" #5720

Closed
3 tasks done
RealKev79 opened this issue Apr 13, 2023 · 7 comments
Closed
3 tasks done

Possibility for wildcards in "ignored domains" #5720

RealKev79 opened this issue Apr 13, 2023 · 7 comments
Assignees
Milestone

Comments

@RealKev79
Copy link

Prerequisites

  • I have checked the Wiki and Discussions and found no answer

  • I have searched other issues and found no duplicates

  • I want to request a feature or enhancement and not ask a question

Description

Within the "ignored domains" in logs-configuration and statistics-configuration I want to add several domains with wildcards because I do not want to "see" every single subdomain or similar from a specific domain. For example I want to add following domain:
*.blabla.org
and this should trigger on "www.blabla.org" and also on "blablablabla.blabla.org"

I have a working laptop and when I am working at home I did not want to see the whole specific company domains.

At the moment I added these into the "disallowed domains" in the DNS-Settings.

Regards
Kevin

@davralin
Copy link

davralin commented Jun 7, 2023

In the same situation myself, I don't want to see my monitoring setup's continous query of my internal hosts - so I want to exclude my entire local DNS-name from the query log.

@RealKev79
How does it work with having those DNS-records in Disallowed domains ? The way I understand the help-text, those domains wont be resolved at all?

@RealKev79
Copy link
Author

RealKev79 commented Jun 7, 2023

@davralin
Yes the domains entered in "disallowed domains" are completly ignored and are not resolved. Because of that "issue" it will be an effort if the domains can entered in the "ignored domains" within the "general settings" / "logs configuration" as I mentioned above. Then the domains are resolved but are excluded from the logs/statistics.

@ainar-g ainar-g added this to the v0.107.37 milestone Aug 25, 2023
adguard pushed a commit that referenced this issue Sep 5, 2023
Updates #5720.

Squashed commit of the following:

commit e8093c9
Merge: df5413e 28fefaf
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Tue Sep 5 15:06:33 2023 +0300

    Merge branch 'master' into 5720-wildcard-ignored-domains

commit df5413e
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Tue Sep 5 14:49:05 2023 +0300

    confmigrate: imp docs

commit 1644d99
Merge: 9542ee1 1e45178
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Tue Sep 5 14:23:42 2023 +0300

    Merge branch 'master' into 5720-wildcard-ignored-domains

commit 9542ee1
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Tue Sep 5 12:48:48 2023 +0300

    all: upd chlog

commit 183f84a
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Fri Sep 1 17:11:31 2023 +0300

    all: imp chlog

commit a704325
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Thu Aug 31 18:59:52 2023 +0300

    all: imp code

commit fe99c3b
Merge: 7f11e94 0182b9e
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Thu Aug 31 18:43:09 2023 +0300

    Merge branch 'master' into 5720-wildcard-ignored-domains

commit 7f11e94
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Wed Aug 30 19:57:51 2023 +0300

    aghnet: add tests

commit f10f919
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Wed Aug 30 18:32:07 2023 +0300

    all: add conf migration

commit a53c14d
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Wed Aug 30 13:37:30 2023 +0300

    all: add ignore engine
@ainar-g
Copy link
Contributor

ainar-g commented Sep 7, 2023

AdBlock syntax is going to be supported in v0.107.37.

@ainar-g ainar-g closed this as completed Sep 7, 2023
@ainar-g ainar-g modified the milestones: v0.107.38, v0.107.37 Sep 7, 2023
@whyisthisbroken
Copy link

So i can now put *in-addr.arpa in the Ignored Field ?
because I still see the entries.
Will there possibly be a UI added? Maybe in the same button where you can also block?

@FFFcat
Copy link

FFFcat commented Sep 7, 2023

So i can now put *in-addr.arpa in the Ignored Field ? because I still see the entries. Will there possibly be a UI added? Maybe in the same button where you can also block?

AdBlock syntax such as ||in-addr.arpa, it's just hidden

@jeverley
Copy link

Is it expected that we should be able to use the AdBlock $client syntax in the rules?

||168.192.in-addr.arpa
||example.com^$client=192.168.1.6

With the above I successfully exclude the arpa queries, but I can still see entries for example.com from the specified client IP.

@gpz1100
Copy link

gpz1100 commented Sep 20, 2024

Is it expected that we should be able to use the AdBlock $client syntax in the rules?

||168.192.in-addr.arpa ||example.com^$client=192.168.1.6

With the above I successfully exclude the arpa queries, but I can still see entries for example.com from the specified client IP.

Have you been able to find a solution to this? I'm trying to do the exact same thing. I have one client (a thermostat) the wants to reach out and touch amazon, every 50 seconds). I can block this by dns or at firewall level (by blocking the entire amazon asn for that client). With dns block, I see a block entry every 50 seconds. I would love to not see that, but still see such entries from other clients.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants