Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lb._dns-sd._udp.<local net address 0.x.x.10/172/192>.in-addr.arpa sent to Upstream DNS server (external) #5567

Closed
3 tasks done
meAThomeDOTcom opened this issue Mar 5, 2023 · 2 comments

Comments

@meAThomeDOTcom
Copy link

Prerequisites

  • I have checked the Wiki and Discussions and found no answer

  • I have searched other issues and found no duplicates

  • I want to report a bug and not ask a question

Operating system type

Linux, Other (please mention the version in the description)

CPU architecture

AMD64

Installation

Docker

Setup

Other (please mention in the description)

AdGuard Home version

v0.107.25

Description

Operating system

Synology DSM 7.1.1-42962 Update 4

Setup

Docker on NAS

Docker version

20.10.3-1308

What did you do?

Basic setup / configuration.
Upstream DNS servers maintained as
udp://<upstream domain>
tcp://<upstream domain>
Private reverse DNS servers maintained as
<local ip - gateway>

Network clients sending in-addr.arpa resolution requests to AGH.

Expected result

.in-addr.arpa requests into private address space (RFC 1918) are forwarded to Private reverse DNS servers (if configured).

Actual result

Requests sent to
<local ip address 0.x.x.10/172/192>.in-addr.arpa are sent as expected to Private reverse DNS servers.
but requestes sent to
lb._dns-sd._udp.<local net address 0.x.x.10/172/192>.in-addr.arpa are sent to Upstream DNS server (potentially external).

Screenshots (if applicable)

Additional information

@ainar-g ainar-g added the needs investigation Needs to be reproduced reliably. label Mar 6, 2023
@ainar-g ainar-g added this to the v0.107.26 milestone Mar 6, 2023
@ainar-g ainar-g added enhancement P3: Medium and removed needs investigation Needs to be reproduced reliably. labels Mar 9, 2023
adguard pushed a commit that referenced this issue Mar 17, 2023
Merge in DNS/adguard-home from 5567-extract-subnet-arpa to master

Updates #5567.

Squashed commit of the following:

commit 288fb40
Merge: e16b3ce 9f7a582
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Fri Mar 17 14:01:39 2023 +0300

    Merge branch 'master' into 5567-extract-subnet-arpa

commit e16b3ce
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Fri Mar 17 13:58:58 2023 +0300

    dnsforward: use netip

commit 265b08c
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Thu Mar 16 19:11:49 2023 +0300

    dnsforward: imp tests more

commit 53a839c
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Thu Mar 16 19:09:15 2023 +0300

    dnsforward: imp naming in tests

commit 74dcccb
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Thu Mar 16 18:59:12 2023 +0300

    dnsforward: imp code & tests more

commit da8badf
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Wed Mar 15 14:52:48 2023 +0300

    all: log changes

commit c491cbf
Merge: 74a9317 2b5e485
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Wed Mar 15 14:44:31 2023 +0300

    Merge branch 'master' into 5567-extract-subnet-arpa

commit 74a9317
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Wed Mar 15 14:42:55 2023 +0300

    dnsforward: imp code, docs

commit 17df1a0
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Tue Mar 14 19:49:10 2023 +0300

    dnsforward: extract subnet from arpa
@EugeneOne1
Copy link
Member

@meAThomeDOTcom, hello and apologies for late response. We've pushed the newest edge build that should handle the cases of this issue. Could you please check if AGH now chooses the upstream properly?

@EugeneOne1
Copy link
Member

@meAThomeDOTcom, we'll close the issue for now, since the enhancement works properly on our test machines. Please feel free to report any problems with the implementation.

@ainar-g ainar-g modified the milestones: v0.107.29, v0.107.28 Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants