Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error when saving configuration #5251

Closed
3 tasks done
Versty opened this issue Dec 9, 2022 · 8 comments
Closed
3 tasks done

Error when saving configuration #5251

Versty opened this issue Dec 9, 2022 · 8 comments
Assignees
@EugeneOne1
Labels
bug P2: High
Milestone
v0.107.21

Comments

@Versty
Copy link

Versty commented Dec 9, 2022

Prerequisites

  • I have checked the Wiki and Discussions and found no answer

  • I have searched other issues and found no duplicates

  • I want to report a bug and not ask a question

Operating system type

Linux, OpenWrt

CPU architecture

AMD64

Installation

GitHub releases or script from README

Setup

On one machine

AdGuard Home version

0.107.20

Description

Steps to reproduce

  1. In the DNS settings change upstream to tls://1.1.1.1
  2. Open the encryption settings screen
  3. Mark the "Enable Encryption" checkbox
  4. Mark the "Redirect to HTTPS automatically"
  5. Add the valid certificate and key
  6. Click the "Save configuration" button

Expected result

Configuration saved successfully, encryption enabled

Actual result

Error: control/tls/configure | starting forwarding dns server: could not reconfigure the server: closing primary resolvers: stopping dns proxy server: failed to close some upstreams: failed to close some connections: 3 errors: "tls: failed to send closeNotify alert (but connection was closed anyway): write tcp 192.XXX.XX.XXX:35292->1.1.1.1:853: write: broken pipe", "tls: failed to send closeNotify alert (but connection was closed anyway): write tcp 192.XXX.XX.XXX:35304->1.1.1.1:853: write: broken pipe", "tls: failed to send closeNotify alert (but connection was closed anyway): write tcp 192.XXX.XX.XXX:38572->1.1.1.1:853: write: broken pipe" | 500
@ainar-g ainar-g added this to the v0.107.21 milestone Dec 9, 2022
@ainar-g
Copy link
Contributor

ainar-g commented Dec 9, 2022

I've seen the same in Cache settings.

@pendie
Copy link

pendie commented Dec 9, 2022

same

@monkitrainer
Copy link

been having this issue since 107.17. dup of #5122

@Eyeborgs Eyeborgs mentioned this issue Dec 9, 2022
Closed
3 tasks
@ainar-g ainar-g changed the title Error when trying to save the encryption configuration Error when saving configuration Dec 12, 2022
@ainar-g ainar-g pinned this issue Dec 12, 2022
@ainar-g ainar-g mentioned this issue Dec 13, 2022
Closed
3 tasks
adguard pushed a commit to AdguardTeam/dnsproxy that referenced this issue Dec 14, 2022
@EugeneOne1
Pull request: 5251-close-ups
dc6b896 
Merge in DNS/dnsproxy from 5251-close-ups to master

Updates AdguardTeam/AdGuardHome#5251.

Squashed commit of the following:

commit c4f01d3
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Wed Dec 14 17:57:19 2022 +0300

    upstream: enhance filtered errs

commit ce33519
Merge: 175680b 0ce51f5
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Wed Dec 14 13:29:27 2022 +0300

    Merge branch 'master' into 5251-close-ups

commit 175680b
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Tue Dec 13 15:06:01 2022 +0300

    upstream: fix doc

commit 9ecfc0b
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Tue Dec 13 14:59:04 2022 +0300

    all: imp docs

commit b275d56
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Tue Dec 13 02:11:13 2022 +0300

    upstream: imp dot

commit 0ed84f4
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Mon Dec 12 20:40:35 2022 +0300

    fastip: fix golangci-lint issues

commit c5ed13b
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Mon Dec 12 20:15:45 2022 +0300

    all: fix staticcheck issues

commit 6c8b28c
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Mon Dec 12 20:05:24 2022 +0300

    upstream: imp more

commit e4a2374
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Mon Dec 12 19:01:57 2022 +0300

    upstream: upd golibs, imp code

commit cae1610
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Mon Dec 12 16:27:21 2022 +0300

    upstream: filter dot errs

commit 51005ab
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Mon Dec 12 14:10:23 2022 +0300

    upstream: use sync pool

commit 81e907c
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Sat Dec 10 03:37:21 2022 +0300

    upstream: imp dot
adguard pushed a commit that referenced this issue Dec 14, 2022
@EugeneOne1
Pull request: 5251-close-ups
d77b743 
Merge in DNS/adguard-home from 5251-close-ups to master

Updates #5251.

Squashed commit of the following:

commit 98a4a9a
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Wed Dec 14 18:31:17 2022 +0300

    all: log changes better

commit af25803
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Wed Dec 14 18:24:42 2022 +0300

    all: log changes

commit 65bb12d
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Wed Dec 14 18:15:41 2022 +0300

    all: upd dnsproxy

commit 24039cd
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Wed Dec 14 17:19:15 2022 +0300

    dnsforward: imp code, docs

commit a40bbd5
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Wed Dec 14 16:43:10 2022 +0300

    dnsforward: log errs instead of return
@EugeneOne1
Copy link
Member

Hello, @pendie, @monkitrainer, @Eyeborgs, and @Commy. I'm mentioning you since you all faced this issue. Could you all please check the latest edge release and give us some feedback on the topic? The issue should be fixed there. Thanks.

Note also that because of Snapcraft outage the Snap release is delayed.

@Eyeborgs
Copy link

@EugeneOne1 The problem has disappeared

@monkitrainer
Copy link

@EugeneOne1 looking good. Thanks!

@EugeneOne1
Copy link
Member

EugeneOne1 commented Dec 15, 2022 •
edited
Loading

It seems, Snap builds are loaded as well.

It actually didn't, sorry for confusing.

Finally, the Snap release is published.

@ainar-g ainar-g modified the milestones: v0.107.22, v0.107.21 Dec 15, 2022
@ainar-g ainar-g closed this as completed Dec 15, 2022
@ainar-g ainar-g unpinned this issue Dec 15, 2022
@Commy
Copy link

Commy commented Dec 15, 2022

@EugeneOne1 Working without issue so far. Thanks for addressing it!

heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
@EugeneOne1 @heyxkhoa
Pull request: 5251-close-ups
0ccfb60 
Merge in DNS/adguard-home from 5251-close-ups to master

Updates AdguardTeam#5251.

Squashed commit of the following:

commit 98a4a9a
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Wed Dec 14 18:31:17 2022 +0300

    all: log changes better

commit af25803
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Wed Dec 14 18:24:42 2022 +0300

    all: log changes

commit 65bb12d
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Wed Dec 14 18:15:41 2022 +0300

    all: upd dnsproxy

commit 24039cd
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Wed Dec 14 17:19:15 2022 +0300

    dnsforward: imp code, docs

commit a40bbd5
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Wed Dec 14 16:43:10 2022 +0300

    dnsforward: log errs instead of return
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EugeneOne1 EugeneOne1

Labels
bug P2: High
Projects
None yet
Milestone
v0.107.21
Development

No branches or pull requests
7 participants
@Commy @ainar-g @EugeneOne1 @Eyeborgs @pendie @monkitrainer @Versty