Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DHCP Server in .12 stops certain IoT devices from connecting #4904

Closed
3 tasks done
jgriffiths014 opened this issue Sep 9, 2022 · 12 comments
Closed
3 tasks done

DHCP Server in .12 stops certain IoT devices from connecting #4904

jgriffiths014 opened this issue Sep 9, 2022 · 12 comments
Assignees
@EugeneOne1
Labels
bug P3: Medium
Milestone
v0.107.13

Comments

@jgriffiths014
Copy link

Prerequisites

  • I have checked the Wiki and Discussions and found no answer

  • I have searched other issues and found no duplicates

  • I want to report a bug and not ask a question

Operating system type

Linux, Other (please mention the version in the description)

CPU architecture

AMD64

Installation

Docker

Setup

On one machine

AdGuard Home version

v0.107.12

Description

What did you do?

updated to v0.107.12, after the DHCP leases expired, my Blink camera system refused to re-connect. Connecting the devices to a guest network that uses a different DHCP server brings the devices back online. rolling back to v0.107.11 also brings the devices back online.

Expected result

All devices should stay online after a DHCP lease renewal

Actual result

devices unable to renew DHCP lease and therefore cannot connect to the network.

Screenshots (if applicable)

Additional information
@ainar-g ainar-g added the needs investigation Needs to be reproduced reliably. label Sep 9, 2022
@EugeneOne1
Copy link
Member

@jgriffiths014, hello and thanks for reporting. Could you please collect a verbose log for us, capturing the moment of DHCP messages interchange? You're welcome to send it to devteam@adguard.com.

@EugeneOne1 EugeneOne1 added the waiting for data Waiting for users to provide more data. label Sep 9, 2022
@jgriffiths014
Copy link
Author

Hi @EugeneOne1 ,

Just emailed a log to the specified email address, I have had to sanitize it a little. The mac address of the device i tested with is 48:78:5e:da:12:0c

Thanks

adguard pushed a commit that referenced this issue Sep 9, 2022
@EugeneOne1
Pull request: 4904 return dhcp msg size
782de99 
Merge in DNS/adguard-home from 4904-rm-padding to master

Updates #4904.
Updates #4903.

Squashed commit of the following:

commit 8533740
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Fri Sep 9 19:38:09 2022 +0300

    dhcpd: return dhcp msg size
@EugeneOne1
Copy link
Member

@jgriffiths014, we've just pushed the newest edge build. It's intended to check the assumption that the message size causes this issue. Could you please give it a try?

@djusHa
Copy link

djusHa commented Sep 10, 2022

My Sonos Play 1 has same issue. No IP Adress from DHCP. Revert back to Version: v0.107.11, is all ok. Pihole working good also.

@EugeneOne1
Copy link
Member

@djusHa, could you please also try the latest edge build? It reverts some changes made in 0.107.12.

@djusHa
Copy link

djusHa commented Sep 11, 2022 •
edited
Loading

@EugeneOne1: Edge build seems to work flawless, DHCP on my Sonos Play 1 works again.
No Problems so far with DHCP on Tasmota Plugs and Tuya Devices, if this is interesting for you.
.lan suffix for my Debian Server works, was broken in 0.107.11, it has fixed ip and .lan configured over /etc/hosts.

So far, so good :-)

@SubtleShuttle
Copy link

Ugh, I bought a new Roku thinking my old one was bad. Found this after the new one came and didn't work either.

@jgriffiths014
Copy link
Author

Sorry @EugeneOne1, I've been away for a few days - I'll reconfigure my instance for you today and grab the logs.

Thanks

@EugeneOne1
Copy link
Member

@rhraziel, have you tried the latest edge build of AdGuard Home. It seems, we've introduced a little bug into DHCP recently.

@EugeneOne1 EugeneOne1 removed the needs investigation Needs to be reproduced reliably. label Sep 12, 2022
@jgriffiths014
Copy link
Author

Hi,

log running latest edge version mailed over for you, everything seems to work - devices rebooted and came back online. Didn't capture in the logs but I reset all leases and rebooted the devices - they came back online ok.

Thanks

@EugeneOne1
Copy link
Member

@jgriffiths014, great to hear. I'll close the issue then, if you don't mind.

@EugeneOne1 EugeneOne1 removed the waiting for data Waiting for users to provide more data. label Sep 12, 2022
@SubtleShuttle
Copy link

@EugeneOne1 Yes, the edge build worked for me.

@thunderclap82 thunderclap82 mentioned this issue Sep 13, 2022
Closed
3 tasks
@ainar-g ainar-g added this to the v0.107.13 milestone Sep 14, 2022
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
@EugeneOne1 @heyxkhoa
Pull request: 4904 return dhcp msg size
ba42cc8 
Merge in DNS/adguard-home from 4904-rm-padding to master

Updates AdguardTeam#4904.
Updates AdguardTeam#4903.

Squashed commit of the following:

commit 8533740
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Fri Sep 9 19:38:09 2022 +0300

    dhcpd: return dhcp msg size
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EugeneOne1 EugeneOne1

Labels
bug P3: Medium
Projects
None yet
Milestone
v0.107.13
Development

No branches or pull requests
5 participants
@ainar-g @djusHa @EugeneOne1 @jgriffiths014 @SubtleShuttle