-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug with "FQDN Client" #4542
Comments
This is a bit weird because domain names are case-insensitive. I have a bunch of clients with advertised NetBIOS names in Pascal case, but AGH normalizes them, as it should. |
You mean to tell me you're running an open resolver? |
Yes but filter by firewall :) |
@CordoWEB, hello and thanks for the report. We're able to reproduce the bug, the ClientID string is indeed case-sensitive for the moment. We're going to fix it soon. |
Thank you so much :) |
Merge in DNS/adguard-home from 4542-clientid-case to master Updates #4542. Squashed commit of the following: commit 2a3111e Author: Eugene Burkov <E.Burkov@AdGuard.COM> Date: Wed May 4 20:44:18 2022 +0300 all: fix changelog link commit 3732def Author: Eugene Burkov <E.Burkov@AdGuard.COM> Date: Wed May 4 20:43:37 2022 +0300 all: log changes commit 9fe1001 Author: Eugene Burkov <E.Burkov@AdGuard.COM> Date: Wed May 4 19:37:33 2022 +0300 dnsforward: lowercase clientid
@CordoWEB, hello again. We've just pushed the latest edge build, that should fix the issue. Could you please check if it does? |
I'm sorry i don't have "test environment" |
@CordoWEB, well, the issue seems resolved, at least on our test machines, so I'll close it for now. Please, feel free to reopen it in case you'll face it again. Thanks again. |
Merge in DNS/adguard-home from 4542-clientid-case to master Updates #4542. Squashed commit of the following: commit 2a3111e Author: Eugene Burkov <E.Burkov@AdGuard.COM> Date: Wed May 4 20:44:18 2022 +0300 all: fix changelog link commit 3732def Author: Eugene Burkov <E.Burkov@AdGuard.COM> Date: Wed May 4 20:43:37 2022 +0300 all: log changes commit 9fe1001 Author: Eugene Burkov <E.Burkov@AdGuard.COM> Date: Wed May 4 19:37:33 2022 +0300 dnsforward: lowercase clientid
Merge in DNS/adguard-home from 4542-clientid-case to master Updates AdguardTeam#4542. Squashed commit of the following: commit 2a3111e Author: Eugene Burkov <E.Burkov@AdGuard.COM> Date: Wed May 4 20:44:18 2022 +0300 all: fix changelog link commit 3732def Author: Eugene Burkov <E.Burkov@AdGuard.COM> Date: Wed May 4 20:43:37 2022 +0300 all: log changes commit 9fe1001 Author: Eugene Burkov <E.Burkov@AdGuard.COM> Date: Wed May 4 19:37:33 2022 +0300 dnsforward: lowercase clientid
When a client use AdguardHome server with a FQDN, "theclient.domain.fr" & "TheClient.domain.fr" are view like differents clients.
This is not good for stats ;(
Adguard Home v0.107.6 on Linux Ubuntu 22.04 et Linux Centos 6.10.
The text was updated successfully, but these errors were encountered: