Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad control/install/get_addresses response #4465

Closed
EugeneOne1 opened this issue Apr 6, 2022 · 0 comments
Closed

Bad control/install/get_addresses response #4465

EugeneOne1 opened this issue Apr 6, 2022 · 0 comments
Assignees
@EugeneOne1
Labels
bug P2: High
Milestone
v0.107.0

Comments

@EugeneOne1
Copy link
Member

In #2846 (vol.4) we've introduced a bug that completely breaks the installation process. The aghnet.NetInterface which implemented the json.Marshaler before has now been implementing the encoding.TextMarshaler. It makes the result an escaped string that can't be properly decoded by the frontend.
@EugeneOne1 EugeneOne1 added this to the v0.108.0 milestone Apr 6, 2022
@EugeneOne1 EugeneOne1 self-assigned this Apr 6, 2022
@adguard adguard closed this as completed in 8bb9546 Apr 6, 2022
@ainar-g ainar-g mentioned this issue Apr 12, 2022
Closed
@ainar-g ainar-g modified the milestones: v0.108.0, v0.107.0 Aug 24, 2022
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
@EugeneOne1 @heyxkhoa
Pull request: 4465 fix ifaces resp
b017673 
Merge in DNS/adguard-home from 4465-bad-ifaces-resp to master

Closes AdguardTeam#4465.

Squashed commit of the following:

commit cc44252
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Wed Apr 6 19:21:40 2022 +0300

    aghnet: fix get_addresses
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EugeneOne1 EugeneOne1

Labels
bug P2: High
Projects
None yet
Milestone
v0.107.0
Development

No branches or pull requests
2 participants
@ainar-g @EugeneOne1