You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, we compile in the date of the build. And we compile it in as plain text.
Reproducible-Builds.org recommends using the commit date instead, given through the environment variable SOURCE_DATE_EPOCH and as a Unix timestamp. This should improve the life of people building their own AGH, such as package maintainers, since this will only require a shallow clone of the repo and the “correct” Go version to build a bit-by-bit identical copy of a binary.
The documentation in scripts/README.md obviously should be updates as well.
@jamesmacwhite, @yurivict, @simonbcn, if I recall correctly, you maintain AdGuard Home packages? Do you have any objections to this?
The text was updated successfully, but these errors were encountered:
@ainar-g Thanks for this. I've contributed to the AdGuardHome package in OpenWrt, but I am not the primary maintainer of it, so I'm probably not the best person to speak for the OpenWrt package as a whole.
I'd imagine this relates to the Makefile and how they are being used when compiling in OpenWrt.
ClosesAdguardTeam#4221.
Squashed commit of the following:
commit c84a569
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date: Tue Feb 1 21:13:30 2022 +0300
all: switch to SOURCE_DATE_EPOCH for source date
Currently, we compile in the date of the build. And we compile it in as plain text.
Reproducible-Builds.org recommends using the commit date instead, given through the environment variable
SOURCE_DATE_EPOCH
and as a Unix timestamp. This should improve the life of people building their own AGH, such as package maintainers, since this will only require a shallow clone of the repo and the “correct” Go version to build a bit-by-bit identical copy of a binary.The documentation in
scripts/README.md
obviously should be updates as well.@jamesmacwhite, @yurivict, @simonbcn, if I recall correctly, you maintain AdGuard Home packages? Do you have any objections to this?
The text was updated successfully, but these errors were encountered: