Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client ID check must take lables into account #3437

Closed
Chinaski1 opened this issue Aug 11, 2021 · 0 comments
Closed

Client ID check must take lables into account #3437

Chinaski1 opened this issue Aug 11, 2021 · 0 comments
Assignees
@ainar-g
Labels
bug P4: Low
Milestone
v0.107.0

Comments

@Chinaski1
Copy link
Member

Steps to reproduce

  1. Create a certificate for example.local.
  2. Request client.myexample.local.

Expected result

Error about the wrong host name.

Actual result

[error] Error in the BeforeRequestHandler: getting clientid: client id check: invalid client id "kostya.m": invalid char '.' at index 6
@Chinaski1 Chinaski1 added this to the v0.107.0 milestone Aug 11, 2021
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
@ainar-g @heyxkhoa
Pull request: dnsforward: fix clientid check
8e8371a 
Closes AdguardTeam#3437.

Squashed commit of the following:

commit fc4207a
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Thu Aug 12 18:22:31 2021 +0300

    dnsforward: imp code, docs

commit 0c608e0
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Thu Aug 12 18:01:22 2021 +0300

    dnsforward: fix clientid check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ainar-g ainar-g

Labels
bug P4: Low
Projects
None yet
Milestone
v0.107.0
Development

No branches or pull requests
2 participants
@ainar-g @Chinaski1