Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install script uses ls -q which is not recognised on OpenWRT Busybox BusyBox v1.33.1 #3361

Closed
3 tasks
mercyground opened this issue Jul 19, 2021 · 2 comments
Closed
3 tasks

Comments

@mercyground
Copy link

Please answer the following questions for yourself before submitting an issue. YOU MAY DELETE THE PREREQUISITES SECTION.

  • I am running the latest version
  • I checked the documentation and found no answer
  • I checked to make sure that this issue has not already been filed

Issue Details

Attempting to install via script as per home page.

root@OpenWrt:~# curl -s -S -L https://raw.githubusercontent.com/AdguardTeam/AdGuardHome/master/scripts/install.sh | sh -s -- -v -c edge
starting AdGuard Home installation script
channel: edge
operating system: linux
cpu type: mips_softfloat
AdGuard Home will be installed into /opt/AdGuardHome
checking curl
checking tar
script is executed with root privileges
ls: unrecognized option: q
BusyBox v1.33.1 (2021-07-17 18:07:55 UTC) multi-call binary.

Usage: ls [-1AaCxdLHRFplinshrSXvctu] [-w WIDTH] [FILE]...

List directory contents

        -1      One column output
        -a      Include entries which start with .
        -A      Like -a, but exclude . and ..
        -x      List by lines
        -d      List directory entries instead of contents
        -L      Follow symlinks
        -H      Follow symlinks on command line
        -R      Recurse
        -p      Append / to dir entries
        -F      Append indicator (one of */=@|) to entries
        -l      Long listing format
        -i      List inode numbers
        -n      List numeric UIDs and GIDs instead of names
        -s      List allocated blocks
        -lc     List ctime
        -lu     List atime
        --full-time     List full date and time
        -h      Human readable sizes (1K 243M 2G)
        --group-directories-first
        -S      Sort by size
        -X      Sort by extension
        -v      Sort by version
        -t      Sort by mtime
        -tc     Sort by ctime
        -tu     Sort by atime
        -r      Reverse sort order
        -w N    Format N columns wide
        --color[={always,never,auto}]   Control coloring
downloading package from https://static.adguard.com/adguardhome/edge/AdGuardHome_linux_mips_softfloat.tar.gz -> AdGuardHome_linux_mips_softfloat.tar.gz

It did install but i wanted to note it as an issue.

BusyBox v1.33.1 (2021-07-17 18:07:55 UTC) multi-call binary.

@ainar-g
Copy link
Contributor

ainar-g commented Jul 20, 2021

Huh, interesting, thank you for the report. We'll fix it soon-ish.

@ainar-g ainar-g self-assigned this Jul 20, 2021
adguard pushed a commit that referenced this issue Jul 20, 2021
Updates #3361.

Squashed commit of the following:

commit 97c13c5
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Tue Jul 20 12:31:29 2021 +0300

    scripts: do not use ls -q
@ainar-g ainar-g added this to the v0.107.0 milestone Jul 20, 2021
@ainar-g
Copy link
Contributor

ainar-g commented Jul 20, 2021

This is fixed on master, and we've also added a rule against it into our programming guidelines. I'll close this for now. Thank you for reporting, and feel free to report any new issues with Busybox or OpenWrt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants