Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SRV record like dnsmasq #2533

Closed
openwrtledediy opened this issue Jan 10, 2021 · 8 comments
Closed

Add SRV record like dnsmasq #2533

openwrtledediy opened this issue Jan 10, 2021 · 8 comments
Assignees
@ainar-g
Labels
feature request P3: Medium
Milestone
v0.106.0

Comments

@openwrtledediy
Copy link

Hi, Guys
How to translate below dnsmasq record to Adguard Home?
srv-host=_vlmcs._tcp.lan,OpenWrt-SE.lan,1688,0,100
Thanks.
@ameshkov
Copy link
Member

@ainar-g can we use $dnsrewrite for this?

@ainar-g
Copy link
Contributor

ainar-g commented Jan 11, 2021

@ameshkov, I don't see why not, but you'll need to decide whether it should go in v0.105.0 or in the next patch.

@ameshkov
Copy link
Member

@ainar-g

Ah, so it's not supported in v0.105 yet?

Nvm, let's plan it for v0.106 then.

@ainar-g ainar-g added this to the v0.106.0 milestone Jan 13, 2021
@DandelionSprout
Copy link
Member

I appear to get SRV records as of 0.105.0-beta2, as well as NAPTR, neither of which I think I've received before, if that is relevant to anything.
image

Admittedly it may also be because I began using my phone's native Android settings for static LAN IP a week ago.

@ameshkov
Copy link
Member

Hmm, @ainar-g how does that response look in serialized form? [object Object] looks weird, is it our mistake?

@ainar-g ainar-g mentioned this issue Jan 28, 2021
Closed
@ainar-g
Copy link
Contributor

ainar-g commented Jan 28, 2021

@ameshkov, @DandelionSprout, it's a real server bug. Filed a separate issue, fix should be ready soon.

adguard pushed a commit to AdguardTeam/urlfilter that referenced this issue Mar 12, 2021
@ainar-g
Pull request: all: add srv records, imp validations, tests
5e150db 
Updates AdguardTeam/AdGuardHome#2498.
Updates AdguardTeam/AdGuardHome#2533.

Squashed commit of the following:

commit 7af563d
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Fri Mar 12 19:08:35 2021 +0300

    all: imp docs, tests

commit 4f48cd2
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Fri Mar 12 18:20:56 2021 +0300

    all: add srv records, imp validations, tests
adguard pushed a commit that referenced this issue Mar 15, 2021
@ainar-g
Pull request: all: add srv handling to dnsrewrite filters
d970b79 
Closes #2498.
Updates #2533.

Squashed commit of the following:

commit 452e0e7
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Fri Mar 12 19:33:18 2021 +0300

    all: add srv handling to dnsrewrite filters
adguard pushed a commit that referenced this issue Mar 15, 2021
@ainar-g
Pull request: dnsforward: fix fqdn in some dns rewrites
75ac1a5 
Updates #2498.
Updates #2533.

Squashed commit of the following:

commit 9eec20a
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Mon Mar 15 16:53:29 2021 +0300

    dnsforward: fix fqdn in some dns rewrites
@ainar-g
Copy link
Contributor

ainar-g commented Mar 15, 2021

@kenyloveg, @DandelionSprout, as of snapshot 75ac1a5 you should be able to send SRV records using these custom rules:

||_xmpp-server._tcp.example.org^$dnsrewrite=NOERROR;SRV;10 60 8080 xmpp.example.org

@ainar-g
Copy link
Contributor

ainar-g commented Mar 18, 2021

I'll close this issue for now. Please feel free to file new issues if you find any problems with the solution.

@ainar-g ainar-g closed this as completed Mar 18, 2021
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
@ainar-g @heyxkhoa
Pull request: all: add srv handling to dnsrewrite filters
4743c09 
Closes AdguardTeam#2498.
Updates AdguardTeam#2533.

Squashed commit of the following:

commit 452e0e7
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Fri Mar 12 19:33:18 2021 +0300

    all: add srv handling to dnsrewrite filters
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
@ainar-g @heyxkhoa
Pull request: dnsforward: fix fqdn in some dns rewrites
c252250 
Updates AdguardTeam#2498.
Updates AdguardTeam#2533.

Squashed commit of the following:

commit 9eec20a
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Mon Mar 15 16:53:29 2021 +0300

    dnsforward: fix fqdn in some dns rewrites
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ainar-g ainar-g

Labels
feature request P3: Medium
Projects
None yet
Milestone
v0.106.0
Development

No branches or pull requests
4 participants
@ainar-g @ameshkov @DandelionSprout @openwrtledediy