Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write to ioutil.Discard in tests #2273

Closed
ainar-g opened this issue Nov 5, 2020 · 0 comments
Closed

Write to ioutil.Discard in tests #2273

ainar-g opened this issue Nov 5, 2020 · 0 comments
Assignees
@EugeneOne1
Labels
enhancement P4: Low
Milestone
v0.104.2

Comments

@ainar-g
Copy link
Contributor

ainar-g commented Nov 5, 2020

When a test fails, we have a lot of unnecessary output from all the logging that the test has done. Use ioutil.Discard as the logs writer during tests instead.
@ainar-g ainar-g added this to the v0.104 milestone Nov 5, 2020
@ainar-g ainar-g modified the milestones: v0.104, v0.105 Nov 11, 2020
adguard pushed a commit that referenced this issue Nov 12, 2020
@EugeneOne1
all: replace default log writer with ioutil.Discard
360e736 
Closes #2273.
adguard pushed a commit to AdguardTeam/golibs that referenced this issue Nov 13, 2020
@EugeneOne1
Pull request: add log writer
ee52d33 
Merge in DNS/golibs from add-log-writer to master

Updates AdguardTeam/AdGuardHome#2273.

Squashed commit of the following:

commit 5e9ca32
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Fri Nov 13 15:28:44 2020 +0300

    log: fix comment

commit 2319364
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Fri Nov 13 15:16:21 2020 +0300

    log: add writer returner
@ainar-g ainar-g modified the milestones: v0.105, v0.104.2 Nov 19, 2020
adguard pushed a commit that referenced this issue Dec 10, 2020
@EugeneOne1 @Blakhard
Pull request: 2273 clean tests output
ce0eebb 
Merge in DNS/adguard-home from 2273-clean-tests-output to master

Closes #2273.

Squashed commit of the following:

commit 7571a33
Merge: f17df0f a19523b
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Mon Nov 16 15:45:30 2020 +0300

    Merge branch 'master' into 2273-clean-tests-output

commit f17df0f
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Mon Nov 16 15:35:42 2020 +0300

    home: move build constraint on top line

commit 3717c8e
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Mon Nov 16 15:24:50 2020 +0300

    all: add improvements to changelog

commit de6d5af
Merge: 43d4f7a 394fc5a
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Mon Nov 16 15:04:38 2020 +0300

    Merge branch 'master' into 2273-clean-tests-output

commit 43d4f7a
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Mon Nov 16 13:38:13 2020 +0300

    dnsfilter: remove redundant test logging

commit 7194c14
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Mon Nov 16 12:19:14 2020 +0300

    testutil: improve comments

commit 9f17ab0
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Sat Nov 14 01:22:08 2020 +0300

    nclient4: fix wrong function name

commit f355749
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Sat Nov 14 01:07:22 2020 +0300

    testutil: fix comments and naming

commit f8c50a2
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Fri Nov 13 14:09:50 2020 +0300

    testutil: create a package and include it

commit f169cdc
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Thu Nov 12 20:15:58 2020 +0300

    agherr: discard loggers output

commit 360e736
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Thu Nov 12 20:09:55 2020 +0300

    all: replace default log writer with ioutil.Discard

    Closes #2273.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EugeneOne1 EugeneOne1

Labels
enhancement P4: Low
Projects
None yet
Milestone
v0.104.2
Development

No branches or pull requests
2 participants
@ainar-g @EugeneOne1