Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rules Special characters "^" not working as expected #1732

Closed
kkkgo opened this issue May 25, 2020 · 2 comments
Closed

Rules Special characters "^" not working as expected #1732

kkkgo opened this issue May 25, 2020 · 2 comments
Assignees
Milestone

Comments

@kkkgo
Copy link

kkkgo commented May 25, 2020

Issue Details

  • Version of AdGuard Home server:
    • v0.102.0

Expected Behavior

^ — separator character mark. Unlike browser ad blocking, there's nothing to "separate" in a hostname, so the only purpose of this character is to mark the end of the hostname.

rule: ||88911.us^
example1 www.88911.us --- match
example2 dualstack.log-334788911.us-east-1.elb.amazonaws.com --notmatch

Actual Behavior

rule: ||88911.us^
example1 www.88911.us    ---  match
example2 dualstack.log-334788911.us-east-1.elb.amazonaws.com   --match
@kkkgo
Copy link
Author

kkkgo commented May 25, 2020

I think the character "-" in the domain name will not work as expected

rule: ||github.com^
match:  dualstack.log.github.com-east-1.elb.amazonaws.com
not match : dualstack.log.github.com1-east-1.elb.amazonaws.com

@ameshkov ameshkov self-assigned this May 25, 2020
@ameshkov ameshkov modified the milestones: v0.102, v0.103 May 25, 2020
@DandelionSprout
Copy link
Member

DandelionSprout commented May 30, 2020

I was not able to replicate the 88911.us example, but I was indeed able to replicate the ||github.com^ example.

I can also tell from my testing that "AdGuard for Windows" and uBlock Origin are unaffected, meaning that the problem is indeed somewhere in AdGuard Home.

adguard pushed a commit to AdguardTeam/urlfilter that referenced this issue Jun 23, 2020
adguard pushed a commit to AdguardTeam/urlfilter that referenced this issue Jun 23, 2020
The syntax is described here:
AdguardTeam/AdGuardHome#1761

Also, this commit fixes this bug:
AdguardTeam/AdGuardHome#1732

Squashed commit of the following:

commit 89ed791
Author: Andrey Meshkov <am@adguard.com>
Date:   Tue Jun 23 14:07:12 2020 +0300

    Fix separator: AdguardTeam/AdGuardHome#1732

commit 4016329
Author: Andrey Meshkov <am@adguard.com>
Date:   Tue Jun 23 13:48:45 2020 +0300

    Added DNSEngine tests

commit 576bf02
Merge: 8ed2f2e 5dd65ce
Author: Andrey Meshkov <am@adguard.com>
Date:   Tue Jun 23 13:16:10 2020 +0300

    Merge with master

commit 8ed2f2e
Author: Andrey Meshkov <am@adguard.com>
Date:   Tue Jun 23 13:06:53 2020 +0300

    Added handling new modifier to the DNS engine

commit aedc51a
Author: Andrey Meshkov <am@adguard.com>
Date:   Tue Jun 23 01:46:56 2020 +0300

    Adding  modifier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants