-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporarily disable with API (and via UI) #1333
Comments
Yeah, there's no such API method at the moment, start-sleep-stop is the only way. |
Thanks! |
Can we close this issue? I doubt that we really need a new API method to temporarily disable the filtering. |
It depends on the users. If there will be upvotes, we'll consider it. Generally, I'd better keep all feature requests open until we are 100% sure that we won't do it. |
i would like to see this feature too! |
I'd like this feature too |
I would really like this feature too. The scenario is like this: I can easily turn on/off AdGuard Home from the web interface, but my wife/kids are not so technical. I could then just make a shortcut on their iphone to turn off the filtering for a short time (say 5 minutes) to test if AdGuard is blocking the website they want to visit. |
Guys, please add upvotes then (upvote reaction on the issue) |
Alternative UI solution #997 #1203 #1450
@danielp123 I understand but you may able to create account for them and add a timed allow list with single rule to unblock all domains for 5min. In this cause; i'm not prefer to see AGH become too simple tool. |
@ameshkov Along with this feature request to temporarily disable filtering via API, and a good reason for making this feature, would be to integrate this "Temporarily disable AdGuard Home DNS filtering protection" API feature into AdGuard for Windows, AdGuard browser extensions, etc. I am a long time user of AdGuard for Windows. Quite often, I have to temporarily disable the AGH DNS filtering because it causes problems on kids iPad games and certain things that other users may need to do from time to time. This may be a tricky request though, in that regard. |
@ameshkov – I know this issue has gone to a bunch of different places, but I've been using:
to enable and disable filtering. Unfortunately, I've noticed that even though filtering is now disabled, the domain is cached as blocked so you have to wait for the cache to clear before the domain will work again. Is this a separate issue that I should file or is there a different API call to turn AdGuard Home off? Thanks for everything, it's a great piece of software. |
@shapiro125 Do you mean browser's cache? Please try requesting the host name via |
@szolin – dig is showing it correctly each time, it appears to be a browser cache issue. If the request is blocked, my browser will continue to block it even after disable adguard. Once it's disabled, the browser will still resolve the domain even after adguard is re-enabled. I know it's working as expected (according to the dig results), so don't know what to do about it. I'm coming from Pi-hole, where their disable seemed to work instantly in browser without cache problems. Thanks! |
Maybe they just set small TTL values. |
@szolin you mean |
or |
Oh, interesting. I noticed What are the performance implications for making that shorter? |
Your devices will make DNS queries for blocked resources more often. Tbh, there are no really serious performance implications, especially if we're talking about AGH that's hosted in the local network and not on some public server. |
I'd love this too. Just noticed that Adguard was disabled for the past day or so because I had forgotten to re-enable it. It would be great to have an option in the UI as well. |
How is that AdGuard related? You're having issues with HA, not AdGuard. Try this to see whether your API is working. It should disable AdGuard |
HTTP auth header may be necessary as well, plz see the openapi folder in AGH sources |
I got hit by this again several times. To avoid this in the future, I updated my script above to ensure it never stays disabled for more than 1 hour. If anyone wants to to use it, it's below. Install
|
This comment was marked as duplicate.
This comment was marked as duplicate.
Is there a ETA for the "new API and UI"? For me, the temporary disabling is an important feature. Sometimes I need to disable the filter and then of course I forget to enable it again - who doesn't remember the situation? |
No precise timeframes, unfortunately. |
I would really love that feature as well. Adguard runs perfectly but there are certain pages/ ads that me or my wife want to follow on purpose that might get blocked. |
Just switched from pihole to Adguard, and I'm sad to see this feature missing. Absolutely nessecary feature in my household. |
do you know the comparison list in the README of this repo? I am thinking about submitting a PR with another line. What do you folks think of it?
|
Lol :) Updated the original feature request with the description of how it will be implemented: #1333 (comment) |
The feature is implemented in the most recent Edge builds, and it's going to be included in the next Beta release. Please fill new issues if you find any bugs with it. |
First of all thank you very much for this feature! It's really useful and I use it quite often 👍🏼 I think I found a minor cosmetic bug: When a pause timer is active while the browser or browser tab is inactive (in the background, not visible, etc.), the value of the countdown is not properly updated when returning to the page (Chrome Without knowing anything of how this is implemented technically, I assume that the countdown is only updated in frontend (JavaScript) code? If so, when a browser (tab) is paused, so are |
We'll look into it, thanks for reporting. |
Is there a timeline when the API is implemented in the stable version? A missed feature since switching from pihole. |
API example:
|
In order to make this work, we need to change how the "Disable protection" button looks like.
Use the same approach as for the "Block" button in the Query Log:
There's a fixed list of options that can be used:
When the protection is paused temporarily, "Enable protection" button becomes a countdown:
Original feature request text (replaced by @ameshkov)
Hello -- I'm trying to figure out if there's a way to disable AdGuard Home temporarily within the API. For example, Pi-hole allows disabling for some number of seconds through theirs (http://pi.hole/admin/api.php?disable=300). Unless I'm missing something, I've only figured out how to switch on vs off or make a script that switches it off, sleeps for a certain number of seconds, and then switches it back on.
Thanks!
The text was updated successfully, but these errors were encountered: